generate-bindings-all.pl should recompile supplemented IDL if its supplemental IDL are added or removed

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Fujii Hironori]

generate-bindings-all.pl was introduced in
<http://trac.webkit.org/changeset/207617>.  Before this change,
updating supplemental_dependency.tmp triggered regenerating all
bindings.  I tried to solve this problem by checking timestamp of
supplemental dependencies.  But, its logic has bugs in following
cases:

* Adding a new supplemental IDL which has older timestamp than supplemented IDL's generated files.
  ⇒ Supplemented IDL should be processed
* Removing a supplemental IDL
  ⇒ Supplemented IDL should be processed
* Changing enabled features
  ⇒ All IDL should be processed

[Fujii Hironori]

*** Bug 163883 has been marked as a duplicate of this bug. ***

[Fujii Hironori]

Created attachment 293008 [details]
Patch

[Fujii Hironori]

Manual test cases of incremental build:

* touch Source/WebCore/dom/Comment.idl
  ⇒ Recompile Comment.idl
* touch Source/WebCore/html/HTMLMediaElement.idl
  ⇒ Recompile HTMLMediaElement.idl, HTMLAudioElement.idl and HTMLVideoElement.idl
* touch Source/WebCore/dom/Node.idl
  ⇒ Recompile a lot of IDL including HTML Elements and SVG Elements.
* touch Source/WebCore/Modules/webdatabase/DOMWindowWebDatabase.idl
  ⇒ Recompile DOMWindowWebDatabase.idl and DOMWindow.idl
* Comment out Modules/webdatabase/DOMWindowWebDatabase.idl in Source/WebCore/CMakeLists.txt
  ⇒ Recompile DOMWindow.idl
* Remove the comment of Modules/webdatabase/DOMWindowWebDatabase.idl
  ⇒ Recompile DOMWindow.idl
* Add "[NoInterfaceObject]" to Source/WebCore/Modules/webdatabase/Database.idl
  ⇒ Recompile Database.idl and DOMWindow.idl (DOMWindowConstructors.idl is updated)
* Removed the "[NoInterfaceObject]" of Source/WebCore/Modules/webdatabase/Database.idl
  ⇒ Recompile Database.idl and DOMWindow.idl (DOMWindowConstructors.idl is updated)
* Enable ro disable features
  ⇒ Recompile all IDL

[Michael Catanzaro]

Did you mean to set r?

[Fujii Hironori]

I just wanted to try EWS. I need more testing before requesting review. Thank you.

[Fujii Hironori]

I've found one more problem that preprocess-idls.pl is not
invoked when a IDL is added or removed.  I didn't notice this bug
because Bug163882 causes infinite preprocessing.

To test this case, I need to stop infinite preprocessing first.

> $ touch WebKitBuild/Debug/DerivedSources/WebCore/{supplemental_dependency.tmp,*Constructors.idl}
> $ ./Tools/Scripts/build-webkit --gtk --debug --64-bit --makeargs="WebCoreBindings"

And, do following test cases:

> * Comment out Modules/webdatabase/DOMWindowWebDatabase.idl in Source/WebCore/CMakeLists.txt
>   ⇒ Recompile DOMWindow.idl
> * Remove the comment of Modules/webdatabase/DOMWindowWebDatabase.idl
>   ⇒ Recompile DOMWindow.idl

[Fujii Hironori]

Created attachment 293114 [details]
Patch

[Michael Catanzaro]

Comment on attachment 293114 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293114&action=review

> Source/WebCore/ChangeLog:13
> +        generetated files.

generetated -> generated

> Source/cmake/WebKitMacros.cmake:110
> +        # because some of them use #if yet.

Just say: "because some of them use #if"

I would prefer to split this change into a separate patch.

[Fujii Hironori]

Created attachment 293141 [details]
Patch

Thank you for reviewing my patch.
I revised the patch.
* Fixed the typo
* Removed the change of WebKitMacros.cmake

[WebKit Commit Bot]

Comment on attachment 293141 [details]
Patch

Clearing flags on attachment: 293141

Committed r208045: <http://trac.webkit.org/changeset/208045>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.