Bug 164028

Summary: [EME] Add no-op Web-facing APIs
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, commit-queue, jer.noble
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 158836    
Attachments:
Description Flags
WIP
none
WIP
none
WIP
none
Patch
none
Patch for landing
none
Patch for landing none

Zan Dobersek
Reported 2016-10-26 13:09:52 PDT
[EME] Add no-op Web-facing APIs
Attachments
WIP (137.30 KB, patch)
2016-10-26 13:35 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
WIP (126.14 KB, patch)
2016-10-27 03:24 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
WIP (123.98 KB, patch)
2016-11-01 10:05 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (124.22 KB, patch)
2016-11-08 04:58 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch for landing (124.15 KB, patch)
2016-11-10 01:29 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch for landing (123.71 KB, patch)
2016-11-10 03:22 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2016-10-26 13:35:20 PDT
The idea is to start with WebIDL definitions and the underlying C++ classes. The implementations would be non-operational for starters, with future patches implementing the relevant algorithms and queries to the platform layer. Incoming patch needs a few more iterations, mostly for the Xcode and Windows build systems, but the gist of it is reviewable.
Zan Dobersek
Comment 2 2016-10-26 13:35:38 PDT
Created attachment 292957 [details] WIP
Zan Dobersek
Comment 3 2016-10-27 03:24:54 PDT
Created attachment 293009 [details] WIP
Zan Dobersek
Comment 4 2016-11-01 10:05:19 PDT
Created attachment 293555 [details] WIP Trying to get the patch building on all EWS configs.
WebKit Commit Bot
Comment 5 2016-11-07 23:01:00 PST
Attachment 293555 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/JSMediaKeySystemAccessCustom.cpp:33: You should add a blank line after implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/bindings/js/JSMediaKeySystemAccessCustom.cpp:33: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/bindings/js/JSMediaKeySessionCustom.cpp:33: You should add a blank line after implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/bindings/js/JSMediaKeySessionCustom.cpp:33: You should not add a blank line before implementation file's own header. [build/include_order] [4] Total errors found: 4 in 48 files If any of these errors are false positives, please file a bug against check-webkit-style.
Zan Dobersek
Comment 6 2016-11-08 04:58:09 PST
Created attachment 294154 [details] Patch
WebKit Commit Bot
Comment 7 2016-11-08 05:00:12 PST
Attachment 294154 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/JSMediaKeySystemAccessCustom.cpp:33: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/bindings/js/JSMediaKeySessionCustom.cpp:33: You should not add a blank line before implementation file's own header. [build/include_order] [4] Total errors found: 2 in 48 files If any of these errors are false positives, please file a bug against check-webkit-style.
Jer Noble
Comment 8 2016-11-08 06:56:40 PST
Comment on attachment 294154 [details] Patch Looks good! We may want to add a runtime-enabled switch for all these new interfaces, in a future patch.
Zan Dobersek
Comment 9 2016-11-10 01:29:00 PST
Created attachment 294348 [details] Patch for landing
WebKit Commit Bot
Comment 10 2016-11-10 01:32:14 PST
Attachment 294348 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/JSMediaKeySystemAccessCustom.cpp:33: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/bindings/js/JSMediaKeySessionCustom.cpp:33: You should not add a blank line before implementation file's own header. [build/include_order] [4] Total errors found: 2 in 48 files If any of these errors are false positives, please file a bug against check-webkit-style.
Zan Dobersek
Comment 11 2016-11-10 03:22:59 PST
Created attachment 294357 [details] Patch for landing
WebKit Commit Bot
Comment 12 2016-11-10 03:24:54 PST
Attachment 294357 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/JSMediaKeySystemAccessCustom.cpp:33: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/bindings/js/JSMediaKeySessionCustom.cpp:33: You should not add a blank line before implementation file's own header. [build/include_order] [4] Total errors found: 2 in 48 files If any of these errors are false positives, please file a bug against check-webkit-style.
Zan Dobersek
Comment 13 2016-11-10 09:09:51 PST
The patch needed an update after the generation of promise code was modified I think yesterday. mac-debug EWS is reporting failures, but the bot seems in bad state and the failures in the build it managed to compile aren't related.
Zan Dobersek
Comment 14 2016-11-10 09:11:49 PST
Comment on attachment 294357 [details] Patch for landing Clearing flags on attachment: 294357 Committed r208539: <http://trac.webkit.org/changeset/208539>
Zan Dobersek
Comment 15 2016-11-10 09:11:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.