Bug 164020

Summary:

First parameter to TextTrack.addCue() / removeCue() should not be nullable

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Media

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, darin, eric.carlson, jer.noble, sam

Priority:

Keywords:

WebExposed

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	commit-queue: commit-queue-

Description Chris Dumez 2016-10-26 09:54:50 PDT

First parameter to TextTrack.addCue() / removeCue() should not be nullable:
- https://html.spec.whatwg.org/#texttrack

Firefox and Chrome agree with the specification.

Comment 1 Chris Dumez 2016-10-26 09:56:29 PDT

Created attachment 292937 [details]
Patch

Comment 2 Eric Carlson 2016-10-26 10:01:31 PDT

Comment on attachment 292937 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292937&action=review

> LayoutTests/ChangeLog:11
> +        * fast/media/texttrack-addCue-null-expected.txt: Added.
> +        * fast/media/texttrack-addCue-null.html: Added.

I think this test should be in LayoutTests/media/track/ with the rest of the text track tests. Almost all of the tests in LayoutTests/fast/media/ are for media queries.

Comment 3 Chris Dumez 2016-10-26 10:05:16 PDT

Created attachment 292939 [details]
Patch

Comment 4 WebKit Commit Bot 2016-10-26 11:19:43 PDT

Comment on attachment 292939 [details]
Patch

Rejecting attachment 292939 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 292939, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/2379801

Comment 5 Chris Dumez 2016-10-26 12:30:13 PDT

Committed r207907: <http://trac.webkit.org/changeset/207907>