Bug 164003

Summary: Updating attribute by textContent must create a single mutation record and custom element reaction
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dbates, esprehn+autocc, kangil.han, koivisto, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 154907    
Attachments:
Description Flags
Fixes the bug
none
Adds CEReactions none

Ryosuke Niwa
Reported 2016-10-25 19:45:35 PDT
When updating an attribute by its Attr node's textContent, WebKit currently creates two mutation records and invokes attributeChangedCallback twice. In accordance with the latest DOM specification, we should create exactly one mutation record and invoke attributeChangedCallback once.
Attachments
Fixes the bug (8.86 KB, patch)
2016-10-25 19:52 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Adds CEReactions (94.72 KB, patch)
2016-10-28 14:18 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-10-25 19:49:44 PDT
<rdar://problem/28951008>
Ryosuke Niwa
Comment 2 2016-10-25 19:52:03 PDT
Created attachment 292866 [details] Fixes the bug
Chris Dumez
Comment 3 2016-10-25 21:02:46 PDT
Comment on attachment 292866 [details] Fixes the bug r=me, good find.
WebKit Commit Bot
Comment 4 2016-10-25 21:47:54 PDT
Comment on attachment 292866 [details] Fixes the bug Clearing flags on attachment: 292866 Committed r207864: <http://trac.webkit.org/changeset/207864>
WebKit Commit Bot
Comment 5 2016-10-25 21:47:59 PDT
All reviewed patches have been landed. Closing bug.
Ryosuke Niwa
Comment 6 2016-10-28 14:18:09 PDT
Reopening to attach new patch.
Ryosuke Niwa
Comment 7 2016-10-28 14:18:12 PDT
Created attachment 293210 [details] Adds CEReactions
Ryosuke Niwa
Comment 8 2016-10-28 14:18:49 PDT
Comment on attachment 293210 [details] Adds CEReactions Oops, wrong bug.
Note You need to log in before you can comment on or make changes to this bug.