Bug 163994

Summary: [Win][Direct2D] Use smart pointers for Direct2D Path types
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebCore Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, pvollan, sabouhallawa, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: All   
Bug Depends on:    
Bug Blocks: 163898    
Attachments:
Description Flags
Patch none

Description Brent Fulgham 2016-10-25 16:18:50 PDT
Switch the D2D Path implementation to use a smart pointer for Direct2D native path types to reduce memory leaks.
Comment 1 Brent Fulgham 2016-10-25 16:28:34 PDT
Created attachment 292843 [details]
Patch

Strip the Path refactoring changes out of Bug 163898.
Comment 2 Alex Christensen 2016-10-25 16:35:49 PDT
Comment on attachment 292843 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292843&action=review

> Source/WebCore/platform/graphics/Path.h:172
> +#if USE(DIRECT2D)
> +        PlatformPathPtr platformPath() const { return m_path.get(); }
> +#else
>          PlatformPathPtr platformPath() const { return m_path; }
> +#endif

It seems like other platforms ought to follow this and use smart pointers.
Comment 3 WebKit Commit Bot 2016-10-25 19:00:34 PDT
Comment on attachment 292843 [details]
Patch

Clearing flags on attachment: 292843

Committed r207863: <http://trac.webkit.org/changeset/207863>
Comment 4 WebKit Commit Bot 2016-10-25 19:00:39 PDT
All reviewed patches have been landed.  Closing bug.