Bug 163994

Summary: [Win][Direct2D] Use smart pointers for Direct2D Path types
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebCore Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, pvollan, sabouhallawa, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: All   
Bug Depends on:    
Bug Blocks: 163898    
Attachments:
Description Flags
Patch none

Brent Fulgham
Reported 2016-10-25 16:18:50 PDT
Switch the D2D Path implementation to use a smart pointer for Direct2D native path types to reduce memory leaks.
Attachments
Patch (9.74 KB, patch)
2016-10-25 16:28 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2016-10-25 16:28:34 PDT
Created attachment 292843 [details] Patch Strip the Path refactoring changes out of Bug 163898.
Alex Christensen
Comment 2 2016-10-25 16:35:49 PDT
Comment on attachment 292843 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292843&action=review > Source/WebCore/platform/graphics/Path.h:172 > +#if USE(DIRECT2D) > + PlatformPathPtr platformPath() const { return m_path.get(); } > +#else > PlatformPathPtr platformPath() const { return m_path; } > +#endif It seems like other platforms ought to follow this and use smart pointers.
WebKit Commit Bot
Comment 3 2016-10-25 19:00:34 PDT
Comment on attachment 292843 [details] Patch Clearing flags on attachment: 292843 Committed r207863: <http://trac.webkit.org/changeset/207863>
WebKit Commit Bot
Comment 4 2016-10-25 19:00:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.