Bug 163966

Summary: IDBDatabase.transaction() should take a union in parameter
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, beidson, commit-queue, darin, esprehn+autocc, jsbell, kondapallykalyan, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://www.w3.org/TR/IndexedDB/#widl-IDBDatabase-transaction-IDBTransaction-DOMString-sequence-DOMString--storeNames-IDBTransactionMode-mode
Attachments:
Description Flags
Patch none

Comment 1 Chris Dumez 2016-10-25 13:06:12 PDT 
Created attachment 292804 [details]
Patch
Comment 2 Sam Weinig 2016-10-25 14:41:42 PDT 
Comment on attachment 292804 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292804&action=review

> Source/WebCore/Modules/indexeddb/IDBDatabase.cpp:179
>      if (objectStores.isEmpty())
>          return Exception { IDBDatabaseException::InvalidAccessError, ASCIILiteral("Failed to execute 'transaction' on 'IDBDatabase': The storeNames parameter was empty.") };

Can this case happen?
Comment 3 Chris Dumez 2016-10-25 14:43:40 PDT 
Comment on attachment 292804 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292804&action=review

>> Source/WebCore/Modules/indexeddb/IDBDatabase.cpp:179
>>          return Exception { IDBDatabaseException::InvalidAccessError, ASCIILiteral("Failed to execute 'transaction' on 'IDBDatabase': The storeNames parameter was empty.") };
> 
> Can this case happen?

database.transaction([]) ?
Comment 4 Chris Dumez 2016-10-25 15:04:45 PDT 
Comment on attachment 292804 [details]
Patch

Clearing flags on attachment: 292804

Committed r207847: <http://trac.webkit.org/changeset/207847>
Comment 5 Chris Dumez 2016-10-25 15:04:50 PDT 
All reviewed patches have been landed.  Closing bug.