Bug 163966 – IDBDatabase.transaction() should take a union in parameter

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Chris Dumez]

IDBDatabase.transaction() should take a union in parameter:
- https://www.w3.org/TR/IndexedDB/#widl-IDBDatabase-transaction-IDBTransaction-DOMString-sequence-DOMString--storeNames-IDBTransactionMode-mode

[Chris Dumez]

Created attachment 292804 [details]
Patch

[Sam Weinig]

Comment on attachment 292804 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292804&action=review

> Source/WebCore/Modules/indexeddb/IDBDatabase.cpp:179
>      if (objectStores.isEmpty())
>          return Exception { IDBDatabaseException::InvalidAccessError, ASCIILiteral("Failed to execute 'transaction' on 'IDBDatabase': The storeNames parameter was empty.") };

Can this case happen?

[Chris Dumez]

Comment on attachment 292804 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292804&action=review

>> Source/WebCore/Modules/indexeddb/IDBDatabase.cpp:179
>>          return Exception { IDBDatabaseException::InvalidAccessError, ASCIILiteral("Failed to execute 'transaction' on 'IDBDatabase': The storeNames parameter was empty.") };
> 
> Can this case happen?

database.transaction([]) ?

[Chris Dumez]

Comment on attachment 292804 [details]
Patch

Clearing flags on attachment: 292804

Committed r207847: <http://trac.webkit.org/changeset/207847>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.