| Summary: | IndexedDB 2.0: Support IDBObjectStore openKeyCursor | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||||
| Component: | WebCore Misc. | Assignee: | Brady Eidson <beidson> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | achristensen, alecflett, cdumez, commit-queue, esprehn+autocc, jsbell, kondapallykalyan | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 160306 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Brady Eidson
2016-10-25 10:23:11 PDT
Created attachment 292810 [details]
Patch
Created attachment 292812 [details]
Patch
Created attachment 292813 [details]
Patch
Comment on attachment 292812 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292812&action=review > Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp:168 > - auto info = IDBCursorInfo::objectStoreCursor(m_transaction.get(), m_info.identifier(), range, direction.value()); > + auto info = IDBCursorInfo::objectStoreCursor(m_transaction.get(), m_info.identifier(), range.get(), direction.value(), IndexedDB::CursorType::KeyAndValue); I was confused by the implicit conversion from a IDBKeyRange* to a IDBKeyRangeData. Since IDBCursorInfo::objectStoreCursor() is always passed a IDBKeyRangeData temporary, maybe this range can be moved into its destination IDBCursorInfo? Not something you have to change here, but just a thought. |