Bug 163954

Summary: IndexedDB 2.0: Support IDBObjectStore openKeyCursor
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, cdumez, commit-queue, esprehn+autocc, jsbell, kondapallykalyan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 160306    
Attachments:
Description Flags
Patch
none
Patch
none
Patch aestes: review+

Brady Eidson
Reported 2016-10-25 10:23:11 PDT
IndexedDB 2.0: Support IDBObjectStore openKeyCursor
Attachments
Patch (24.25 KB, patch)
2016-10-25 13:34 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (24.19 KB, patch)
2016-10-25 13:40 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (24.02 KB, patch)
2016-10-25 13:40 PDT, Brady Eidson 		aestes: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2016-10-25 10:23:33 PDT
<rdar://problem/28806930>
Brady Eidson
Comment 2 2016-10-25 13:34:55 PDT
Created attachment 292810 [details] Patch
Brady Eidson
Comment 3 2016-10-25 13:40:14 PDT
Created attachment 292812 [details] Patch
Brady Eidson
Comment 4 2016-10-25 13:40:51 PDT
Created attachment 292813 [details] Patch
Andy Estes
Comment 5 2016-10-25 13:49:44 PDT
Comment on attachment 292812 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292812&action=review > Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp:168 > - auto info = IDBCursorInfo::objectStoreCursor(m_transaction.get(), m_info.identifier(), range, direction.value()); > + auto info = IDBCursorInfo::objectStoreCursor(m_transaction.get(), m_info.identifier(), range.get(), direction.value(), IndexedDB::CursorType::KeyAndValue); I was confused by the implicit conversion from a IDBKeyRange* to a IDBKeyRangeData. Since IDBCursorInfo::objectStoreCursor() is always passed a IDBKeyRangeData temporary, maybe this range can be moved into its destination IDBCursorInfo? Not something you have to change here, but just a thought.
Brady Eidson
Comment 6 2016-10-25 14:46:02 PDT
https://trac.webkit.org/changeset/207845
Note You need to log in before you can comment on or make changes to this bug.