Bug 163952

Summary: [MediaStream] Add "has capture device" bit to media state flags
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, jer.noble, ryanhaddad, thiago.lacerda, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 163965    
Bug Blocks:    
Attachments:
Description Flags
Proposed patch. jer.noble: review+

Eric Carlson
Reported 2016-10-25 10:18:37 PDT
Add "has active capture device" bit to media state flags
Attachments
Proposed patch. (12.99 KB, patch)
2016-10-25 10:24 PDT, Eric Carlson 		jer.noble: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2016-10-25 10:24:17 PDT
Created attachment 292773 [details] Proposed patch.
Eric Carlson
Comment 2 2016-10-25 10:40:33 PDT
Committed r207827: https://trac.webkit.org/r207827
Eric Carlson
Comment 3 2016-10-25 11:04:55 PDT
Plus https://trac.webkit.org/r207828 to define the WK2 flag.
Ryan Haddad
Comment 4 2016-10-25 12:17:10 PDT
The test added with this change is timing out on Mac WK1/WK2. WK1 has a repeated error in the result: FAIL window.internals.isPagePlayingAudio() should be false. Threw exception TypeError: window.internals.isPagePlayingAudio is not a function. (In 'window.internals.isPagePlayingAudio()', 'window.internals.isPagePlayingAudio' is undefined) https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20(Tests)/builds/919 https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK1%20(Tests)/builds/990
Ryan Haddad
Comment 5 2016-10-25 12:18:23 PDT
(In reply to comment #4) > The test added with this change is timing out on Mac WK1/WK2. WK1 has a > repeated error in the result: > > FAIL window.internals.isPagePlayingAudio() should be false. Threw exception > TypeError: window.internals.isPagePlayingAudio is not a function. (In > 'window.internals.isPagePlayingAudio()', > 'window.internals.isPagePlayingAudio' is undefined) > > https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20(Tests)/ > builds/919 > https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK1%20(Tests)/ > builds/990 Correction, webaudio/web-audio-is-playing.html is an existing test that is now failing.
WebKit Commit Bot
Comment 6 2016-10-25 12:37:10 PDT
Re-opened since this is blocked by bug 163965
Eric Carlson
Comment 7 2016-10-25 13:11:12 PDT
Recommitted r207838: in https://trac.webkit.org/r207838
Eric Carlson
Comment 8 2016-10-25 13:13:01 PDT
Correction: relanded as r207839: https://trac.webkit.org/207839
Eric Carlson
Comment 9 2016-10-26 08:12:39 PDT
Plus r207898: https://trac.webkit.org/r207898
Note You need to log in before you can comment on or make changes to this bug.