Bug 163949

Summary:

[cmake] Don't add -fPIC flag when on Windows (MinGW)

Product:

WebKit

Reporter:

Konstantin Tokarev <annulen>

Component:

Tools / Tests

Assignee:

Konstantin Tokarev <annulen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, lforschler, mcatanzaro, ossy

Priority:

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Konstantin Tokarev 2016-10-25 09:34:23 PDT

-fPIC flag does not do anything on Windows and produces warning noise with MinGW. There is no position independent code in Unix sense on 32-bit Windows, and 64-bit Windows code is always relocatable.

For reference see https://gcc.gnu.org/ml/gcc-patches/2015-08/msg00836.html

Comment 1 Konstantin Tokarev 2016-10-25 09:35:26 PDT

Created attachment 292763 [details]
Patch

Comment 2 Konstantin Tokarev 2016-10-25 10:29:50 PDT

Comment on attachment 292763 [details]
Patch

Clearing flags on attachment: 292763

Committed r207826: <http://trac.webkit.org/changeset/207826>

Comment 3 Konstantin Tokarev 2016-10-25 10:29:57 PDT

All reviewed patches have been landed.  Closing bug.