Bug 163949

Summary: [cmake] Don't add -fPIC flag when on Windows (MinGW)
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: Tools / TestsAssignee: Konstantin Tokarev <annulen>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, lforschler, mcatanzaro, ossy
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Konstantin Tokarev
Reported 2016-10-25 09:34:23 PDT
-fPIC flag does not do anything on Windows and produces warning noise with MinGW. There is no position independent code in Unix sense on 32-bit Windows, and 64-bit Windows code is always relocatable. For reference see https://gcc.gnu.org/ml/gcc-patches/2015-08/msg00836.html
Attachments
Patch (1.87 KB, patch)
2016-10-25 09:35 PDT, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2016-10-25 09:35:26 PDT
Created attachment 292763 [details] Patch
Konstantin Tokarev
Comment 2 2016-10-25 10:29:50 PDT
Comment on attachment 292763 [details] Patch Clearing flags on attachment: 292763 Committed r207826: <http://trac.webkit.org/changeset/207826>
Konstantin Tokarev
Comment 3 2016-10-25 10:29:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.