Bug 163949 - [cmake] Don't add -fPIC flag when on Windows (MinGW)
Summary: [cmake] Don't add -fPIC flag when on Windows (MinGW)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Konstantin Tokarev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-25 09:34 PDT by Konstantin Tokarev
Modified: 2016-10-25 10:29 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.87 KB, patch)
2016-10-25 09:35 PDT, Konstantin Tokarev 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Tokarev 2016-10-25 09:34:23 PDT 
-fPIC flag does not do anything on Windows and produces warning noise with MinGW. There is no position independent code in Unix sense on 32-bit Windows, and 64-bit Windows code is always relocatable.

For reference see https://gcc.gnu.org/ml/gcc-patches/2015-08/msg00836.html
Comment 1 Konstantin Tokarev 2016-10-25 09:35:26 PDT 
Created attachment 292763 [details]
Patch
Comment 2 Konstantin Tokarev 2016-10-25 10:29:50 PDT 
Comment on attachment 292763 [details]
Patch

Clearing flags on attachment: 292763

Committed r207826: <http://trac.webkit.org/changeset/207826>
Comment 3 Konstantin Tokarev 2016-10-25 10:29:57 PDT 
All reviewed patches have been landed.  Closing bug.