Bug 163945

Summary: [cmake] Check if jscLib and WebKitGUID targets exist before using them
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: Tools / TestsAssignee: Konstantin Tokarev <annulen>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, lforschler, pvollan
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Konstantin Tokarev
Reported 2016-10-25 08:23:19 PDT
Currently these targets are used under WIN32 condition, however they are defined in PlatformWin.cmake, causing CMake warnings if port supports WIN32 but does not use PlatformWin.cmake
Attachments
Patch (2.57 KB, patch)
2016-10-25 08:29 PDT, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2016-10-25 08:29:04 PDT
Created attachment 292753 [details] Patch
WebKit Commit Bot
Comment 2 2016-10-25 12:17:46 PDT
Comment on attachment 292753 [details] Patch Clearing flags on attachment: 292753 Committed r207831: <http://trac.webkit.org/changeset/207831>
WebKit Commit Bot
Comment 3 2016-10-25 12:17:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.