Bug 163929

Summary:

URLParser should match old URL::parse with %2E in path

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ryanhaddad

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	ap: review+, buildbot: commit-queue-
Archive of layout-test-results from ews124 for ios-simulator-wk2	none

Alex Christensen

Reported 2016-10-24 17:18:51 PDT

URLParser should match old URL::parse with %2E in path

Attachments
Patch (12.52 KB, patch) 2016-10-24 17:20 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (23.55 KB, patch) 2016-10-24 17:33 PDT, Alex Christensen	ap: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (15.73 MB, application/zip) 2016-10-24 18:31 PDT, Build Bot	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2016-10-24 17:20:11 PDT

Created attachment 292683 [details] Patch

Alex Christensen

Comment 2 2016-10-24 17:33:09 PDT

Created attachment 292684 [details] Patch

Alexey Proskuryakov

Comment 3 2016-10-24 17:55:16 PDT

Comment on attachment 292684 [details] Patch R=me pending EWS.

Build Bot

Comment 4 2016-10-24 18:31:37 PDT

Comment on attachment 292684 [details] Patch Attachment 292684 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2361837 New failing tests: fetch/fetch-url-serialization.html

Build Bot

Comment 5 2016-10-24 18:31:40 PDT

Created attachment 292695 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Alex Christensen

Comment 6 2016-10-24 18:34:44 PDT

http://trac.webkit.org/changeset/207795

Alex Christensen

Comment 7 2016-10-24 18:35:01 PDT

(note: also updated fetch/fetch-url-serialization-expected.txt)

Ryan Haddad

Comment 8 2016-10-24 19:12:24 PDT

This change appears to have caused API test failures. Tests that failed: URLParserTest.AdditionalTests WebKit1.LoadInvalidURLRequest WebKit2.LoadInvalidURLRequest Tests that timed out: URLParserTest.DefaultPort URLParserTest.ParserDifferences https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK1%20(Tests)/builds/967

Ryan Haddad

Comment 9 2016-10-24 20:49:24 PDT

Reverted r207795 for reason: Introduced API test failures on iOS and macOS. Committed r207803: <http://trac.webkit.org/changeset/207803>

Alex Christensen

Comment 10 2016-10-24 21:43:41 PDT

http://trac.webkit.org/changeset/207805 I had accidentally committed a local change unconditionally enabling URLParser everywhere.

Alex Christensen

Comment 11 2016-10-25 00:05:25 PDT

https://trac.webkit.org/r207811

Note You need to log in before you can comment on or make changes to this bug.