Summary: | [WebIDL] Move more types over to the new JSConverter based toJS functions | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | alecflett, beidson, cdumez, commit-queue, jsbell | ||||||||||
Priority: | P2 | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Sam Weinig
2016-10-24 16:23:20 PDT
Created attachment 292675 [details]
Patch
Created attachment 292679 [details]
Patch
Comment on attachment 292679 [details] Patch Attachment 292679 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2361739 New failing tests: fast/forms/date/input-valueasdate-date.html fast/forms/time/time-valueasdate.html fast/forms/month/input-valueasdate.html fast/forms/month/input-valueasdate-month.html Created attachment 292693 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Created attachment 292713 [details]
Patch
Comment on attachment 292713 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292713&action=review > Source/WebCore/bindings/js/JSDOMIterator.h:42 > +enum class JSDOMIteratorType { > + Set, > + Map > +}; How about putting this on one line? > Source/WebCore/bindings/js/JSDOMIterator.h:81 > +template<typename JSWrapper, typename IteratorTraits> > class JSDOMIterator: public JSDOMObject { This too, how about putting it on one line? Also, space after JSDOMIterator before colon please. > Source/WebCore/bindings/js/JSDOMIterator.h:131 > + JSC::MarkedArgumentBuffer args; Could use a whole word here, arguments. > Source/WebCore/bindings/js/JSDOMIterator.h:172 > + return JSC::JSValue(); Could write { } instead of JSC::JSValue(). > Source/WebCore/bindings/js/JSDOMIterator.h:193 > + return JSC::JSValue(); Ditto. > Source/WebCore/bindings/js/JSDOMIterator.h:216 > +template<typename JSIterator> > +JSC::JSValue iteratorForEach(JSC::ExecState& state, typename JSIterator::Wrapper& thisObject, JSC::ThrowScope& scope) Same idea of a single line, but not as sure since so many things above have to be split into multiple lines. Committed r207829: <http://trac.webkit.org/changeset/207829> |