Bug 163914

Summary:

Web Inspector: Remove dead code in FrameTreeElement

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, buildbot, commit-queue, joepeck, mattbaker, nvasilyev, rniwa, timothy, webkit-bug-importer

Priority:

Keywords:

DoNotImportToRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none
Archive of layout-test-results from ews106 for mac-yosemite-wk2	none
Archive of layout-test-results from ews125 for ios-simulator-wk2	none

Joseph Pecoraro

Reported 2016-10-24 14:50:53 PDT

Summary: Remove dead code in FrameTreeElement this._downloadingPage doesn't appear to be doing anything!

Attachments
[PATCH] Proposed Fix (1.42 KB, patch) 2016-10-24 14:52 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (1.46 MB, application/zip) 2016-10-24 17:42 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (13.74 MB, application/zip) 2016-10-24 18:18 PDT, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2016-10-24 14:52:23 PDT

Created attachment 292657 [details] [PATCH] Proposed Fix

Build Bot

Comment 2 2016-10-24 17:42:12 PDT

Comment on attachment 292657 [details] [PATCH] Proposed Fix Attachment 292657 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2361642 New failing tests: svg/wicd/test-rightsizing-b.xhtml

Build Bot

Comment 3 2016-10-24 17:42:15 PDT

Created attachment 292685 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 4 2016-10-24 18:18:50 PDT

Comment on attachment 292657 [details] [PATCH] Proposed Fix Attachment 292657 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2361754 New failing tests: svg/wicd/test-rightsizing-a.xhtml

Build Bot

Comment 5 2016-10-24 18:18:53 PDT

Created attachment 292691 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Joseph Pecoraro

Comment 6 2016-10-24 21:34:11 PDT

Comment on attachment 292657 [details] [PATCH] Proposed Fix Failures are unrelated

Blaze Burg

Comment 7 2016-10-25 12:42:31 PDT

Comment on attachment 292657 [details] [PATCH] Proposed Fix rs=moi

WebKit Commit Bot

Comment 8 2016-10-25 13:06:52 PDT

Comment on attachment 292657 [details] [PATCH] Proposed Fix Clearing flags on attachment: 292657 Committed r207838: <http://trac.webkit.org/changeset/207838>

WebKit Commit Bot

Comment 9 2016-10-25 13:06:56 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.