Bug 163914 - Web Inspector: Remove dead code in FrameTreeElement
Summary: Web Inspector: Remove dead code in FrameTreeElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2016-10-24 14:50 PDT by Joseph Pecoraro
Modified: 2016-10-25 13:06 PDT (History)
9 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (1.42 KB, patch)
2016-10-24 14:52 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (1.46 MB, application/zip)
2016-10-24 17:42 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (13.74 MB, application/zip)
2016-10-24 18:18 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-10-24 14:50:53 PDT
Summary:
Remove dead code in FrameTreeElement

this._downloadingPage doesn't appear to be doing anything!
Comment 1 Joseph Pecoraro 2016-10-24 14:52:23 PDT
Created attachment 292657 [details]
[PATCH] Proposed Fix
Comment 2 Build Bot 2016-10-24 17:42:12 PDT
Comment on attachment 292657 [details]
[PATCH] Proposed Fix

Attachment 292657 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2361642

New failing tests:
svg/wicd/test-rightsizing-b.xhtml
Comment 3 Build Bot 2016-10-24 17:42:15 PDT
Created attachment 292685 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 4 Build Bot 2016-10-24 18:18:50 PDT
Comment on attachment 292657 [details]
[PATCH] Proposed Fix

Attachment 292657 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2361754

New failing tests:
svg/wicd/test-rightsizing-a.xhtml
Comment 5 Build Bot 2016-10-24 18:18:53 PDT
Created attachment 292691 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 6 Joseph Pecoraro 2016-10-24 21:34:11 PDT
Comment on attachment 292657 [details]
[PATCH] Proposed Fix

Failures are unrelated
Comment 7 Brian Burg 2016-10-25 12:42:31 PDT
Comment on attachment 292657 [details]
[PATCH] Proposed Fix

rs=moi
Comment 8 WebKit Commit Bot 2016-10-25 13:06:52 PDT
Comment on attachment 292657 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 292657

Committed r207838: <http://trac.webkit.org/changeset/207838>
Comment 9 WebKit Commit Bot 2016-10-25 13:06:56 PDT
All reviewed patches have been landed.  Closing bug.