Bug 163906

Summary: The URLSearchParams constructor should take a union in parameter
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, darin, esprehn+autocc, gyuyoung.kim, kondapallykalyan, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://url.spec.whatwg.org/#urlsearchparams
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2016-10-24 12:10:03 PDT
The URLSearchParams constructor should take a union in parameter: - https://url.spec.whatwg.org/#urlsearchparams
Attachments
Patch (3.17 KB, patch)
2016-10-24 12:11 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (3.17 KB, patch)
2016-10-24 13:23 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-10-24 12:11:26 PDT
Created attachment 292640 [details] Patch
Darin Adler
Comment 2 2016-10-24 12:36:47 PDT
Comment on attachment 292640 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292640&action=review > Source/WebCore/html/URLSearchParams.h:59 > +Ref<URLSearchParams> URLSearchParams::create(const StringOrURLSearchParams& variant, DOMURL* associatedURL) If we put this in the header, it has to be marked inline.
Chris Dumez
Comment 3 2016-10-24 13:23:45 PDT
Created attachment 292647 [details] Patch
WebKit Commit Bot
Comment 4 2016-10-26 16:18:42 PDT
Comment on attachment 292647 [details] Patch Clearing flags on attachment: 292647 Committed r207914: <http://trac.webkit.org/changeset/207914>
WebKit Commit Bot
Comment 5 2016-10-26 16:18:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.