Bug 163896

Summary: Dumping of op_negate bytecode is broken.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, msaboff, sbarati
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. none

Description Mark Lam 2016-10-24 10:15:31 PDT
It's thinks the bytecode consists of only 3 machine words, when it consists of 4.
Comment 1 Mark Lam 2016-10-24 10:16:11 PDT
(In reply to comment #0)
> It's thinks the bytecode consists of only 3 machine words, when it consists
> of 4.

/It's/It/
Comment 2 Mark Lam 2016-10-24 10:18:44 PDT
Created attachment 292621 [details]
proposed patch.
Comment 3 Darin Adler 2016-10-24 10:21:53 PDT
Comment on attachment 292621 [details]
proposed patch.

Do we have regression tests for this sort of thing?
Comment 4 Mark Lam 2016-10-24 10:23:53 PDT
(In reply to comment #3)
> Comment on attachment 292621 [details]
> proposed patch.
> 
> Do we have regression tests for this sort of thing?

Not that I know of.  The dumper is a debugging tool, and it fails instantaneously on use right at the site of use.  So, it should be easy to debug and fix.
Comment 5 WebKit Commit Bot 2016-10-24 10:56:29 PDT
Comment on attachment 292621 [details]
proposed patch.

Clearing flags on attachment: 292621

Committed r207765: <http://trac.webkit.org/changeset/207765>
Comment 6 WebKit Commit Bot 2016-10-24 10:56:34 PDT
All reviewed patches have been landed.  Closing bug.