Bug 163889

Summary: [CodeGenerator] Only allow a single interface or standalone dictionary per WebIDL file
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, kondapallykalyan, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch cdumez: review+

Description Zan Dobersek 2016-10-24 07:28:02 PDT
[CodeGenerator] Only allow a single interface or standalone dictionary per WebIDL file
Comment 1 Zan Dobersek 2016-10-24 07:41:24 PDT
Created attachment 292609 [details]
Patch
Comment 2 Zan Dobersek 2016-10-24 07:44:32 PDT
Comment on attachment 292609 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292609&action=review

> Source/WebCore/ChangeLog:29
> +        * bindings/scripts/test/attribute.idl: Copied from Source/WebCore/bindings/scripts/test/TestException.idl.
> +        * bindings/scripts/test/readonly.idl: Copied from Source/WebCore/bindings/scripts/test/TestException.idl.

These two could probably be merged into one test case.
Comment 3 Zan Dobersek 2016-10-24 07:53:57 PDT
Created attachment 292610 [details]
Patch
Comment 4 Chris Dumez 2016-10-24 09:37:27 PDT
Comment on attachment 292610 [details]
Patch

Makes sense, r=me
Comment 5 Zan Dobersek 2016-10-24 11:32:26 PDT
Committed r207770: <http://trac.webkit.org/changeset/207770>