Bug 163889

Summary: [CodeGenerator] Only allow a single interface or standalone dictionary per WebIDL file
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, kondapallykalyan, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch cdumez: review+

Zan Dobersek
Reported 2016-10-24 07:28:02 PDT
[CodeGenerator] Only allow a single interface or standalone dictionary per WebIDL file
Attachments
Patch (8.99 KB, patch)
2016-10-24 07:41 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (48.66 KB, patch)
2016-10-24 07:53 PDT, Zan Dobersek 		cdumez: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2016-10-24 07:41:24 PDT
Created attachment 292609 [details] Patch
Zan Dobersek
Comment 2 2016-10-24 07:44:32 PDT
Comment on attachment 292609 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292609&action=review > Source/WebCore/ChangeLog:29 > + * bindings/scripts/test/attribute.idl: Copied from Source/WebCore/bindings/scripts/test/TestException.idl. > + * bindings/scripts/test/readonly.idl: Copied from Source/WebCore/bindings/scripts/test/TestException.idl. These two could probably be merged into one test case.
Zan Dobersek
Comment 3 2016-10-24 07:53:57 PDT
Created attachment 292610 [details] Patch
Chris Dumez
Comment 4 2016-10-24 09:37:27 PDT
Comment on attachment 292610 [details] Patch Makes sense, r=me
Zan Dobersek
Comment 5 2016-10-24 11:32:26 PDT
Committed r207770: <http://trac.webkit.org/changeset/207770>
Note You need to log in before you can comment on or make changes to this bug.