Bug 163880

Summary:

[CodeGeneratorJS] Enum generation uses NeverDestroyed<>, doesn't include it

Product:

WebKit

Reporter:

Zan Dobersek <zan>

Component:

New Bugs

Assignee:

Zan Dobersek <zan>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

cdumez, commit-queue, youennf

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Zan Dobersek 2016-10-24 01:26:52 PDT

[CodeGeneratorJS] Enum generation uses NeverDestroyed<>, doesn't include it

Comment 1 Zan Dobersek 2016-10-24 01:32:45 PDT

Created attachment 292595 [details]
Patch

Comment 2 youenn fablet 2016-10-24 02:21:48 PDT

Comment on attachment 292595 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292595&action=review

> Source/WebCore/ChangeLog:16
> +        specified in the same file.

Can we add a binding test to cover this then?

Comment 3 Zan Dobersek 2016-10-24 02:33:15 PDT

Comment on attachment 292595 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292595&action=review

>> Source/WebCore/ChangeLog:16
>> +        specified in the same file.
> 
> Can we add a binding test to cover this then?

The problem is that standalone dictionaries don't generate enumeration conversion code ATM. But I have a patch to fix that, so this AddToImplIncludes() call can be patched there.

Comment 4 Zan Dobersek 2016-10-24 03:18:07 PDT


*** This bug has been marked as a duplicate of bug 163885 ***