Bug 163880

Summary: [CodeGeneratorJS] Enum generation uses NeverDestroyed<>, doesn't include it
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: cdumez, commit-queue, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Zan Dobersek
Reported 2016-10-24 01:26:52 PDT
[CodeGeneratorJS] Enum generation uses NeverDestroyed<>, doesn't include it
Attachments
Patch (2.05 KB, patch)
2016-10-24 01:32 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2016-10-24 01:32:45 PDT
Created attachment 292595 [details] Patch
youenn fablet
Comment 2 2016-10-24 02:21:48 PDT
Comment on attachment 292595 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292595&action=review > Source/WebCore/ChangeLog:16 > + specified in the same file. Can we add a binding test to cover this then?
Zan Dobersek
Comment 3 2016-10-24 02:33:15 PDT
Comment on attachment 292595 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292595&action=review >> Source/WebCore/ChangeLog:16 >> + specified in the same file. > > Can we add a binding test to cover this then? The problem is that standalone dictionaries don't generate enumeration conversion code ATM. But I have a patch to fix that, so this AddToImplIncludes() call can be patched there.
Zan Dobersek
Comment 4 2016-10-24 03:18:07 PDT
*** This bug has been marked as a duplicate of bug 163885 ***
Note You need to log in before you can comment on or make changes to this bug.