Bug 163875

Summary:

Avoid unnecessary full style resolution in getComputedStyle for non-inherited properties

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	buildbot: commit-queue-
Archive of layout-test-results from ews105 for mac-yosemite-wk2	none
Archive of layout-test-results from ews124 for ios-simulator-wk2	none
Archive of layout-test-results from ews112 for mac-yosemite	none
Archive of layout-test-results from ews102 for mac-yosemite	none
patch	kling: review+

Antti Koivisto

Reported 2016-10-23 13:10:37 PDT

Optimize.

Attachments
patch (10.05 KB, patch) 2016-10-23 14:55 PDT, Antti Koivisto	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (1.27 MB, application/zip) 2016-10-23 15:56 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (9.40 MB, application/zip) 2016-10-23 16:08 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews112 for mac-yosemite (1.91 MB, application/zip) 2016-10-23 23:21 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews102 for mac-yosemite (1.19 MB, application/zip) 2016-10-23 23:25 PDT, Build Bot	no flags	Details
patch (10.75 KB, patch) 2016-10-24 02:15 PDT, Antti Koivisto	kling: review+	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2016-10-23 14:55:42 PDT

Created attachment 292556 [details] patch

Darin Adler

Comment 2 2016-10-23 15:35:19 PDT

Comment on attachment 292556 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=292556&action=review > Source/WebCore/css/StyleResolver.cpp:1820 > + // Color is an inherited property so depending on it effecively makes the property inherited. The word effectively is misspelled here.

Build Bot

Comment 3 2016-10-23 15:56:13 PDT

Comment on attachment 292556 [details] patch Attachment 292556 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2353063 New failing tests: css3/parse-alignment-of-root-elements.html

Build Bot

Comment 4 2016-10-23 15:56:15 PDT

Created attachment 292559 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 5 2016-10-23 16:08:38 PDT

Comment on attachment 292556 [details] patch Attachment 292556 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2353086 New failing tests: css3/parse-alignment-of-root-elements.html

Build Bot

Comment 6 2016-10-23 16:08:41 PDT

Created attachment 292562 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 7 2016-10-23 23:21:54 PDT

Comment on attachment 292556 [details] patch Attachment 292556 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2355741 New failing tests: css3/parse-alignment-of-root-elements.html

Build Bot

Comment 8 2016-10-23 23:21:57 PDT

Created attachment 292584 [details] Archive of layout-test-results from ews112 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 9 2016-10-23 23:25:25 PDT

Comment on attachment 292556 [details] patch Attachment 292556 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2355832 New failing tests: css3/parse-alignment-of-root-elements.html

Build Bot

Comment 10 2016-10-23 23:25:28 PDT

Created attachment 292585 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5

Antti Koivisto

Comment 11 2016-10-24 02:15:32 PDT

Created attachment 292598 [details] patch

Antti Koivisto

Comment 12 2016-10-24 02:54:04 PDT

https://trac.webkit.org/r207755

Note You need to log in before you can comment on or make changes to this bug.