Bug 163870

Summary: [CSS Parser] Unprefix -webkit-writing-mode
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: CSSAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: ryanhaddad, zalan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=163904
https://bugs.webkit.org/show_bug.cgi?id=163905
Attachments:
Description Flags
Patch
none
Patch
none
Patch
zalan: review+, buildbot: commit-queue-
Archive of layout-test-results from ews123 for ios-simulator-wk2 none

Dave Hyatt
Reported 2016-10-23 09:20:45 PDT
The SVG fill and stroke properties are no longer stored as SVGPaint CSSValues in the back end parser, so the apply code needs to handle it.
Attachments
Patch (5.60 KB, patch)
2016-10-23 09:22 PDT, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
Patch (5.54 KB, patch)
2016-10-23 09:24 PDT, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
Patch (41.73 KB, patch)
2016-10-23 15:01 PDT, Dave Hyatt 		zalan: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (9.47 MB, application/zip)
2016-10-23 16:20 PDT, Build Bot 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2016-10-23 09:22:17 PDT
Created attachment 292547 [details] Patch
Dave Hyatt
Comment 2 2016-10-23 09:24:01 PDT
Created attachment 292548 [details] Patch
alan
Comment 3 2016-10-23 09:37:53 PDT
Changelog entry?
Dave Hyatt
Comment 4 2016-10-23 15:01:09 PDT
Created attachment 292557 [details] Patch
Build Bot
Comment 5 2016-10-23 16:20:45 PDT
Comment on attachment 292557 [details] Patch Attachment 292557 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2353122 New failing tests: svg/text/text-align-06-b.svg svg/text/text-vkern.svg svg/batik/text/verticalText.svg svg/W3C-SVG-1.1/text-align-06-b.svg svg/batik/text/verticalTextOnPath.svg
Build Bot
Comment 6 2016-10-23 16:20:49 PDT
Created attachment 292563 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Dave Hyatt
Comment 7 2016-10-24 07:43:01 PDT
Landed in r207756. Other platforms may need to rebaseline some things. I have no idea why the ios-sim is failing. It's acting like it didn't even apply the patch.
Dave Hyatt
Comment 8 2016-10-24 07:43:57 PDT
I meant r207757.
Ryan Haddad
Comment 9 2016-10-24 12:14:42 PDT
This change caused the ios-simulator failures mentioned above (https://bugs.webkit.org/show_bug.cgi?id=163904), as well as flaky failures / assertion failures on mac with http/tests/misc/acid2.html and http/tests/misc/acid2-pixel.html (https://bugs.webkit.org/show_bug.cgi?id=163905)
Note You need to log in before you can comment on or make changes to this bug.