Bug 163863

Summary: addEventListener() / removeEventListener() should use a union for last parameter
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, darin, dbates, esprehn+autocc, kangil.han, kondapallykalyan, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Chris Dumez 2016-10-22 20:26:09 PDT 
addEventListener() / removeEventListener() should use a union for last parameter:
- https://dom.spec.whatwg.org/#eventtarget
Comment 1 Chris Dumez 2016-10-22 20:34:50 PDT 
Created attachment 292531 [details]
Patch
Comment 2 Chris Dumez 2016-10-23 11:06:22 PDT 
Comment on attachment 292531 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292531&action=review

> Source/WebCore/bindings/js/JSDOMConvert.h:643
> +            return std::move<WTF::CheckMoveParameter>(ConditionalConverter<ReturnType, IDLBoolean, hasBooleanType>::convert(state, value).value());

Also fixes Boolean support in unions.
Comment 3 WebKit Commit Bot 2016-10-23 15:58:32 PDT 
Comment on attachment 292531 [details]
Patch

Clearing flags on attachment: 292531

Committed r207734: <http://trac.webkit.org/changeset/207734>
Comment 4 WebKit Commit Bot 2016-10-23 15:58:37 PDT 
All reviewed patches have been landed.  Closing bug.