Bug 163855

Summary: [MediaStream] Separate media capture and audio playback muting
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, jer.noble, thiago.lacerda, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch.
none
Proposed patch.
darin: review+
Patch for landing.
none
Updated patch for landing. none

Eric Carlson
Reported 2016-10-22 14:35:34 PDT
The host application should be able to mute media capture and audio playback independently.
Attachments
Proposed patch. (23.59 KB, patch)
2016-10-23 21:45 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Proposed patch. (24.26 KB, patch)
2016-10-24 09:06 PDT, Eric Carlson 		darin: review+
DetailsFormatted DiffDiff
Patch for landing. (25.36 KB, patch)
2016-10-24 10:12 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Updated patch for landing. (25.41 KB, patch)
2016-10-24 10:18 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2016-10-22 14:36:03 PDT
<rdar://problem/28827186>
Eric Carlson
Comment 2 2016-10-23 21:45:00 PDT
Created attachment 292579 [details] Proposed patch.
Eric Carlson
Comment 3 2016-10-24 09:06:32 PDT
Created attachment 292616 [details] Proposed patch.
Darin Adler
Comment 4 2016-10-24 10:00:13 PDT
Comment on attachment 292616 [details] Proposed patch. I think an isAudioMuted helper function would help keep this code easy to read. Is the new failure of fast/mediastream/MediaStreamTrack-stop.html due to the patch?
Eric Carlson
Comment 5 2016-10-24 10:12:34 PDT
Created attachment 292619 [details] Patch for landing.
Eric Carlson
Comment 6 2016-10-24 10:18:19 PDT
Created attachment 292620 [details] Updated patch for landing.
Eric Carlson
Comment 7 2016-10-24 10:19:29 PDT
(In reply to comment #4) > Comment on attachment 292616 [details] > Proposed patch. > > I think an isAudioMuted helper function would help keep this code easy to > read. > Agreed, fixed. > Is the new failure of fast/mediastream/MediaStreamTrack-stop.html due to the > patch? Yes, fixed.
Eric Carlson
Comment 8 2016-10-24 10:56:39 PDT
Committed r207764: https://trac.webkit.org/r207764
Note You need to log in before you can comment on or make changes to this bug.