Summary: | [MediaStream] Separate media capture and audio playback muting | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||||||||
Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | dino, jer.noble, thiago.lacerda, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | Other | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Eric Carlson
2016-10-22 14:35:34 PDT
Created attachment 292579 [details]
Proposed patch.
Created attachment 292616 [details]
Proposed patch.
Comment on attachment 292616 [details]
Proposed patch.
I think an isAudioMuted helper function would help keep this code easy to read.
Is the new failure of fast/mediastream/MediaStreamTrack-stop.html due to the patch?
Created attachment 292619 [details]
Patch for landing.
Created attachment 292620 [details]
Updated patch for landing.
(In reply to comment #4) > Comment on attachment 292616 [details] > Proposed patch. > > I think an isAudioMuted helper function would help keep this code easy to > read. > Agreed, fixed. > Is the new failure of fast/mediastream/MediaStreamTrack-stop.html due to the > patch? Yes, fixed. Committed r207764: https://trac.webkit.org/r207764 |