Bug 163855

Summary: [MediaStream] Separate media capture and audio playback muting
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, jer.noble, thiago.lacerda, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch.
none
Proposed patch.
darin: review+
Patch for landing.
none
Updated patch for landing. none

Description Eric Carlson 2016-10-22 14:35:34 PDT
The host application should be able to mute media capture and audio playback independently.
Comment 1 Eric Carlson 2016-10-22 14:36:03 PDT
<rdar://problem/28827186>
Comment 2 Eric Carlson 2016-10-23 21:45:00 PDT
Created attachment 292579 [details]
Proposed patch.
Comment 3 Eric Carlson 2016-10-24 09:06:32 PDT
Created attachment 292616 [details]
Proposed patch.
Comment 4 Darin Adler 2016-10-24 10:00:13 PDT
Comment on attachment 292616 [details]
Proposed patch.

I think an isAudioMuted helper function would help keep this code easy to read.

Is the new failure of fast/mediastream/MediaStreamTrack-stop.html due to the patch?
Comment 5 Eric Carlson 2016-10-24 10:12:34 PDT
Created attachment 292619 [details]
Patch for landing.
Comment 6 Eric Carlson 2016-10-24 10:18:19 PDT
Created attachment 292620 [details]
Updated patch for landing.
Comment 7 Eric Carlson 2016-10-24 10:19:29 PDT
(In reply to comment #4)
> Comment on attachment 292616 [details]
> Proposed patch.
> 
> I think an isAudioMuted helper function would help keep this code easy to
> read.
> 
Agreed, fixed.

> Is the new failure of fast/mediastream/MediaStreamTrack-stop.html due to the
> patch?
Yes, fixed.
Comment 8 Eric Carlson 2016-10-24 10:56:39 PDT
Committed r207764: https://trac.webkit.org/r207764