Cleanup kjs_window

• Component: WebCore JavaScript
• Status: RESOLVED FIXED

[Sam Weinig]

Most of the content of kjs_window can be move to more appropriate places (to DOMWindow, WindowFeatures, etc.)

[Sam Weinig]

*** Bug 16386 has been marked as a duplicate of this bug. ***

[Sam Weinig]

Created attachment 17826 [details]
First round of cleanup

[Darin Adler]

Comment on attachment 17826 [details]
First round of cleanup

Please run the sort-Xcode-project-file script on the project file.

+    // - dialogHide: trusted && WindowFeatures::boolFeature(features, "dialoghide"), makes dialog hide when you print
+    // - help: WindowFeatures::boolFeature(features, "help", true), makes help icon appear in dialog (what does it do on Windows?)
+    // - unadorned: trusted && WindowFeatures::boolFeature(features, "unadorned");

Seems a little strange here. Global replace problem?

+static bool isSeparator(::UChar c)

I don't think you need the :: here. It was needed because of "using namespace KJS".

+    {}

We usually put those braces on separate lines.

Where's the update to the .pro and .bkl files?

Otherwise looks fine.

[Sam Weinig]

Created attachment 17937 [details]
move PausedTimeouts

[Sam Weinig]

The first patch was landed in r28592.

[Darin Adler]

Comment on attachment 17937 [details]
move PausedTimeouts

r=me

[Sam Weinig]

Second patch landed in r28779.

[Sam Weinig]

Created attachment 17943 [details]
move ScheduledAction

[Maciej Stachowiak]

Comment on attachment 17943 [details]
move ScheduledAction

Please try to use separate bugs for separate patches. Otherwise the state of the bug gets confusing. 

r=me

[Sam Weinig]

Third patch landed in r28794.  Closing this bug, but will follow up with other bugs for more specific single tasks.