Bug 163848

Summary: [Render Tree Mutation] First letter should not mutate the render tree while in layout.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, dbates, joone, koivisto, rniwa, simon.fraser
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 175417, 175479    
Bug Blocks: 15602, 163849    
Attachments:
Description Flags
patch
buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-elcapitan
none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2
none
Archive of layout-test-results from ews114 for mac-elcapitan
none
Archive of layout-test-results from ews123 for ios-simulator-wk2
none
patch
buildbot: commit-queue-
Archive of layout-test-results from ews101 for mac-elcapitan
none
Archive of layout-test-results from ews107 for mac-elcapitan-wk2
none
Archive of layout-test-results from ews112 for mac-elcapitan
none
Archive of layout-test-results from ews122 for ios-simulator-wk2
none
patch
none
patch
none
patch none

Description zalan 2016-10-22 07:42:06 PDT
RenderBlock::::updateFirstLetter()
RenderBlock::computePreferredLogicalWidths()
RenderTableCell::layout()
Comment 1 Antti Koivisto 2017-08-09 07:07:42 PDT
Created attachment 317698 [details]
patch
Comment 2 Build Bot 2017-08-09 08:24:41 PDT
Comment on attachment 317698 [details]
patch

Attachment 317698 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4284263

New failing tests:
fast/css-generated-content/quote-first-letter.html
imported/blink/fast/css/first-letter-range-insert.html
Comment 3 Build Bot 2017-08-09 08:24:42 PDT
Created attachment 317702 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 Build Bot 2017-08-09 08:29:54 PDT
Comment on attachment 317698 [details]
patch

Attachment 317698 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4284269

New failing tests:
fast/css-generated-content/quote-first-letter.html
imported/blink/fast/css/first-letter-range-insert.html
Comment 5 Build Bot 2017-08-09 08:29:56 PDT
Created attachment 317703 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 6 Build Bot 2017-08-09 08:36:22 PDT
Comment on attachment 317698 [details]
patch

Attachment 317698 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4284277

New failing tests:
fast/css-generated-content/quote-first-letter.html
imported/blink/fast/css/first-letter-range-insert.html
Comment 7 Build Bot 2017-08-09 08:36:23 PDT
Created attachment 317704 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 8 Build Bot 2017-08-09 10:20:04 PDT
Comment on attachment 317698 [details]
patch

Attachment 317698 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4284664

New failing tests:
fast/css-generated-content/quote-first-letter.html
imported/blink/fast/css/first-letter-range-insert.html
Comment 9 Build Bot 2017-08-09 10:20:06 PDT
Created attachment 317717 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 10 Antti Koivisto 2017-08-10 01:41:13 PDT
<rdar://problem/33402718>
Comment 11 Antti Koivisto 2017-08-10 07:37:08 PDT
Created attachment 317805 [details]
patch
Comment 12 Build Bot 2017-08-10 08:47:23 PDT
Comment on attachment 317805 [details]
patch

Attachment 317805 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4290134

New failing tests:
imported/blink/fast/css/first-letter-render-quote.html
fast/text-autosizing/ios/first-letter.html
Comment 13 Build Bot 2017-08-10 08:47:25 PDT
Created attachment 317809 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 14 Build Bot 2017-08-10 08:53:49 PDT
Comment on attachment 317805 [details]
patch

Attachment 317805 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4290150

New failing tests:
imported/blink/fast/css/first-letter-render-quote.html
fast/text-autosizing/ios/first-letter.html
Comment 15 Build Bot 2017-08-10 08:53:50 PDT
Created attachment 317810 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 16 Build Bot 2017-08-10 09:02:57 PDT
Comment on attachment 317805 [details]
patch

Attachment 317805 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4290149

New failing tests:
imported/blink/fast/css/first-letter-render-quote.html
fast/text-autosizing/ios/first-letter.html
Comment 17 Build Bot 2017-08-10 09:02:59 PDT
Created attachment 317811 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 18 Build Bot 2017-08-10 09:18:02 PDT
Comment on attachment 317805 [details]
patch

Attachment 317805 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4290156

New failing tests:
imported/blink/fast/css/first-letter-render-quote.html
fast/text-autosizing/ios/first-letter.html
Comment 19 Build Bot 2017-08-10 09:18:04 PDT
Created attachment 317816 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 20 Antti Koivisto 2017-08-12 02:31:16 PDT
Created attachment 317990 [details]
patch
Comment 21 Build Bot 2017-08-12 02:33:21 PDT
Attachment 317990 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/TextAutoSizing.cpp:36:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 22 Antti Koivisto 2017-08-12 02:35:49 PDT
Created attachment 317991 [details]
patch
Comment 23 Build Bot 2017-08-12 02:38:13 PDT
Attachment 317991 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/TextAutoSizing.cpp:36:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 24 Antti Koivisto 2017-08-12 02:39:56 PDT
Created attachment 317992 [details]
patch
Comment 25 WebKit Commit Bot 2017-08-14 00:10:21 PDT
Comment on attachment 317992 [details]
patch

Clearing flags on attachment: 317992

Committed r220646: <http://trac.webkit.org/changeset/220646>
Comment 26 WebKit Commit Bot 2017-08-14 00:10:23 PDT
All reviewed patches have been landed.  Closing bug.