Bug 175417 - Text renderer updates should be done by RenderTreeUpdater
Summary: Text renderer updates should be done by RenderTreeUpdater
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 163848
  Show dependency treegraph
 
Reported: 2017-08-10 01:40 PDT by Antti Koivisto
Modified: 2017-08-10 08:35 PDT (History)
12 users (show)

See Also:


Attachments
patch (9.58 KB, patch)
2017-08-10 01:49 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2017-08-10 01:40:42 PDT
Currently Text does some direct render tree mutations.
Comment 1 Antti Koivisto 2017-08-10 01:49:15 PDT
Created attachment 317797 [details]
patch
Comment 2 Andreas Kling 2017-08-10 02:49:38 PDT
Comment on attachment 317797 [details]
patch

r=me
Comment 3 WebKit Commit Bot 2017-08-10 03:20:56 PDT
Comment on attachment 317797 [details]
patch

Clearing flags on attachment: 317797

Committed r220523: <http://trac.webkit.org/changeset/220523>
Comment 4 WebKit Commit Bot 2017-08-10 03:20:58 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-08-10 03:22:14 PDT
<rdar://problem/33824787>
Comment 6 Ryan Haddad 2017-08-10 08:35:36 PDT
(In reply to WebKit Commit Bot from comment #3)
> Comment on attachment 317797 [details]
> patch
> 
> Clearing flags on attachment: 317797
> 
> Committed r220523: <http://trac.webkit.org/changeset/220523>
This change broke the Windows build (as EWS predicted): https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/3582