Bug 163843

Summary:

Improve MiniBrowser window titles for URLs without paths and with no title

Product:

WebKit

Reporter:

mitz

Component:

Tools / Tests

Assignee:

mitz

Status:

RESOLVED FIXED

Severity:

Normal

CC:

lforschler, sam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Use the full URL if all else fails	darin: review+

mitz

Reported 2016-10-22 00:12:41 PDT

If the URL doesn’t have a path and the webpage doesn’t have a title, WebKit2 windows show “(null)” in the title, and WebKit1 windows raise an exception, trying to set the NSWindow’s title to nil.

Attachments
Use the full URL if all else fails (3.52 KB, patch) 2016-10-22 00:23 PDT, mitz	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

mitz

Comment 1 2016-10-22 00:23:35 PDT

Created attachment 292481 [details] Use the full URL if all else fails

mitz

Comment 2 2016-10-22 09:33:14 PDT

Committed <https://trac.webkit.org/r207713>.

Note You need to log in before you can comment on or make changes to this bug.