Summary: | Move SVG from ExceptionCode to Exception | ||
---|---|---|---|
Product: | WebKit | Reporter: | Darin Adler <darin> |
Component: | Bindings | Assignee: | Darin Adler <darin> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | achristensen, andersca, buildbot, cdumez, commit-queue, rniwa, sam, youennf |
Priority: | P2 | ||
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Attachments: |
Description
Darin Adler
2016-10-21 21:40:33 PDT
Created attachment 292463 [details]
Patch
Attachment 292463 [details] did not pass style-queue:
ERROR: Source/WebCore/svg/SVGAnimationElement.h:160: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
Total errors found: 1 in 80 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 292463 [details] Patch Attachment 292463 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2342993 New failing tests: svg/W3C-SVG-1.1-SE/types-dom-05-b.svg svg/animations/svgangle-animation-rad-to-grad.html svg/custom/sheet-title.svg svg/dom/SVGAngle.html svg/dom/valueAsString-null.html svg/dom/SVGLength-px-with-context.html svg/animations/svgangle-animation-deg-to-grad.html svg/dom/SVGPreserveAspectRatio.html svg/dom/SVGLength-px.html Created attachment 292476 [details]
Archive of layout-test-results from ews102 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 292463 [details] Patch Attachment 292463 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2343000 New failing tests: svg/W3C-SVG-1.1-SE/types-dom-05-b.svg svg/animations/svgangle-animation-rad-to-grad.html svg/custom/sheet-title.svg svg/dom/SVGAngle.html svg/dom/valueAsString-null.html svg/dom/SVGLength-px-with-context.html svg/animations/svgangle-animation-deg-to-grad.html svg/dom/SVGPreserveAspectRatio.html svg/dom/SVGLength-px.html Created attachment 292477 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 292463 [details] Patch Attachment 292463 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2343004 New failing tests: svg/W3C-SVG-1.1-SE/types-dom-05-b.svg svg/custom/sheet-title.svg svg/dom/SVGAngle.html svg/dom/valueAsString-null.html svg/dom/SVGLength-px-with-context.html svg/dom/SVGPreserveAspectRatio.html svg/dom/SVGLength-px.html Created attachment 292478 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 292463 [details] Patch Attachment 292463 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2343028 New failing tests: svg/W3C-SVG-1.1-SE/types-dom-05-b.svg svg/animations/svgangle-animation-rad-to-grad.html svg/custom/sheet-title.svg svg/dom/SVGAngle.html svg/dom/valueAsString-null.html svg/dom/SVGLength-px-with-context.html svg/animations/svgangle-animation-deg-to-grad.html svg/dom/SVGPreserveAspectRatio.html svg/dom/SVGLength-px.html Created attachment 292479 [details]
Archive of layout-test-results from ews116 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 292499 [details]
Patch
Attachment 292499 [details] did not pass style-queue:
ERROR: Source/WebCore/svg/SVGAnimationElement.h:160: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
Total errors found: 1 in 81 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Everything passing on EWS. Ready for review. Comment on attachment 292499 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292499&action=review r=me > Source/WebCore/svg/SVGGlyphRefElement.idl:23 > + [Reflect=glyphRef] attribute DOMString glyphRef; Wouldn't [Reflect] work? (In reply to comment #14) > > Source/WebCore/svg/SVGGlyphRefElement.idl:23 > > + [Reflect=glyphRef] attribute DOMString glyphRef; > > Wouldn't [Reflect] work? Nope. [Reflect] will try to reflect with an attribute named "glyphref", all lowercase. But the SVG attribute is named "glyphRef" with a capital R. The actual attribute string still has a lowercase R but it won’t compile unless I specify it like this. Might be worth returning later to fix this small mess. Comment on attachment 292499 [details] Patch Clearing flags on attachment: 292499 Committed r207716: <http://trac.webkit.org/changeset/207716> All reviewed patches have been landed. Closing bug. |