Bug 163802

Summary: Slow and big Heap methods should not be inline
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 163562    
Attachments:
Description Flags
the patch
none
the patch
keith_miller: review+
patch for landing none

Description Filip Pizlo 2016-10-21 10:40:18 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2016-10-21 10:42:02 PDT 
Created attachment 292372 [details]
the patch
Comment 2 Filip Pizlo 2016-10-21 10:47:09 PDT 
Created attachment 292374 [details]
the patch
Comment 3 Filip Pizlo 2016-10-21 10:48:23 PDT 
Comment on attachment 292374 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292374&action=review

> Source/JavaScriptCore/heap/HeapInlines.h:-155
> -inline void Heap::reportExtraMemoryAllocated(size_t size)
> -{
> -    if (size > minExtraMemory) 
> -        reportExtraMemoryAllocatedSlowCase(size);
> -}
> -

Hmmm, maybe I shouldn't have made this inline.  I'll run benchmarks and find out. :-)
Comment 4 Keith Miller 2016-10-21 10:48:51 PDT 
Comment on attachment 292374 [details]
the patch

r=me.
Comment 5 Filip Pizlo 2016-10-21 13:40:16 PDT 
Created attachment 292391 [details]
patch for landing
Comment 6 Filip Pizlo 2016-10-22 12:37:53 PDT 
Landed in https://trac.webkit.org/changeset/207714