Summary: | Slow and big Heap methods should not be inline | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||||
Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, keith_miller, mark.lam, msaboff, saam | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 163562 | ||||||||||
Attachments: |
|
Description
Filip Pizlo
2016-10-21 10:40:18 PDT
Created attachment 292372 [details]
the patch
Created attachment 292374 [details]
the patch
Comment on attachment 292374 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=292374&action=review > Source/JavaScriptCore/heap/HeapInlines.h:-155 > -inline void Heap::reportExtraMemoryAllocated(size_t size) > -{ > - if (size > minExtraMemory) > - reportExtraMemoryAllocatedSlowCase(size); > -} > - Hmmm, maybe I shouldn't have made this inline. I'll run benchmarks and find out. :-) Comment on attachment 292374 [details]
the patch
r=me.
Created attachment 292391 [details]
patch for landing
Landed in https://trac.webkit.org/changeset/207714 |