Bug 163802

Summary: Slow and big Heap methods should not be inline
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 163562    
Attachments:
Description Flags
the patch
none
the patch
keith_miller: review+
patch for landing none

Filip Pizlo
Reported 2016-10-21 10:40:18 PDT
Patch forthcoming.
Attachments
the patch (10.12 KB, patch)
2016-10-21 10:42 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (11.42 KB, patch)
2016-10-21 10:47 PDT, Filip Pizlo 		keith_miller: review+
DetailsFormatted DiffDiff
patch for landing (12.05 KB, patch)
2016-10-21 13:40 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2016-10-21 10:42:02 PDT
Created attachment 292372 [details] the patch
Filip Pizlo
Comment 2 2016-10-21 10:47:09 PDT
Created attachment 292374 [details] the patch
Filip Pizlo
Comment 3 2016-10-21 10:48:23 PDT
Comment on attachment 292374 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=292374&action=review > Source/JavaScriptCore/heap/HeapInlines.h:-155 > -inline void Heap::reportExtraMemoryAllocated(size_t size) > -{ > - if (size > minExtraMemory) > - reportExtraMemoryAllocatedSlowCase(size); > -} > - Hmmm, maybe I shouldn't have made this inline. I'll run benchmarks and find out. :-)
Keith Miller
Comment 4 2016-10-21 10:48:51 PDT
Comment on attachment 292374 [details] the patch r=me.
Filip Pizlo
Comment 5 2016-10-21 13:40:16 PDT
Created attachment 292391 [details] patch for landing
Filip Pizlo
Comment 6 2016-10-22 12:37:53 PDT
Landed in https://trac.webkit.org/changeset/207714
Note You need to log in before you can comment on or make changes to this bug.