Bug 163794

Summary: [CSS Parser] Add support for -webkit-line-box-contain
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: CSSAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch zalan: review+

Dave Hyatt
Reported 2016-10-21 09:57:12 PDT
Add support for -webkit-line-box-contain.
Attachments
Patch (3.70 KB, patch)
2016-10-21 09:58 PDT, Dave Hyatt 		zalan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2016-10-21 09:58:10 PDT
Created attachment 292359 [details] Patch
WebKit Commit Bot
Comment 2 2016-10-21 09:59:09 PDT
Attachment 292359 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
zalan
Comment 3 2016-10-21 10:00:21 PDT
Comment on attachment 292359 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292359&action=review > Source/WebCore/css/parser/CSSPropertyParser.cpp:3049 > +static RefPtr<CSSValue> consumeLineBoxContain(CSSParserTokenRange& range) const range?
Dave Hyatt
Comment 4 2016-10-21 10:06:05 PDT
Fix landed in r207679.
Note You need to log in before you can comment on or make changes to this bug.