Bug 163792

Summary:

WebGL2RenderingContext.texSubImage3D() should use a union instead of overloading

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Canvas

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, darin, dino, esprehn+autocc, graouts, gyuyoung.kim, kondapallykalyan, sam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

163764

Bug Blocks:

163791

Attachments:

Description	Flags
Patch	none

Description Chris Dumez 2016-10-21 09:48:47 PDT

WebGL2RenderingContext.texSubImage3D() should use a union instead of overloading for 
- https://www.khronos.org/registry/webgl/specs/latest/2.0/#3.7 (for texSubImage3D)
- https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14 (for TexImageSource)

TexImageSource is defined as:
typedef (ImageBitmap or
         ImageData or
         HTMLImageElement or
         HTMLCanvasElement or
         HTMLVideoElement) TexImageSource;

Comment 1 Chris Dumez 2016-10-21 09:50:12 PDT

Created attachment 292358 [details]
Patch

Comment 2 WebKit Commit Bot 2016-10-21 10:58:54 PDT

Comment on attachment 292358 [details]
Patch

Clearing flags on attachment: 292358

Committed r207685: <http://trac.webkit.org/changeset/207685>

Comment 3 WebKit Commit Bot 2016-10-21 10:58:59 PDT

All reviewed patches have been landed.  Closing bug.