Bug 163761

Summary: [JSC] Drop isEnvironmentRecord type info flag and use JSType information instead
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, ggaren, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Yusuke Suzuki
Reported 2016-10-20 15:19:08 PDT
JSType already has information: WithScope, GlobalObject, ModuleLexicalEnvironment etc. Instead of using a type info flag bit, just use these type info.
Attachments
Patch (20.55 KB, patch)
2016-10-20 17:53 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2016-10-20 17:53:08 PDT
Created attachment 292297 [details] Patch
Keith Miller
Comment 2 2016-10-20 18:02:44 PDT
Comment on attachment 292297 [details] Patch r=me. Nice, we can always use more bits!
Yusuke Suzuki
Comment 3 2016-10-20 18:06:45 PDT
Comment on attachment 292297 [details] Patch Thanks :D
WebKit Commit Bot
Comment 4 2016-10-20 18:35:59 PDT
Comment on attachment 292297 [details] Patch Clearing flags on attachment: 292297 Committed r207652: <http://trac.webkit.org/changeset/207652>
WebKit Commit Bot
Comment 5 2016-10-20 18:36:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.