Bug 163757

Summary: Use IntSize::unclampedArea() in PDFDocumentImage::updateCachedImageIfNeeded()
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: PDFAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, sabouhallawa, simon.fraser, thorton
Priority: P2    
Version: Safari 10   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=163696
https://bugs.webkit.org/show_bug.cgi?id=163670
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2016-10-20 13:40:14 PDT
Use IntSize::unclampedArea() in PDFDocumentImage::updateCachedImageIfNeeded(). Broken out from the original patch posted to Bug 163696. Noticed while looking for places where "width * height *4" was computed.
Attachments
Patch v1 (2.45 KB, patch)
2016-10-20 13:41 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2016-10-20 13:41:38 PDT
Created attachment 292245 [details] Patch v1
Brent Fulgham
Comment 2 2016-10-21 09:12:44 PDT
Comment on attachment 292245 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=292245&action=review Nice! r=me. > Source/WebCore/ChangeLog:13 > + previously. Also gets rid of more safeCast<size_t>() use. Yay!
WebKit Commit Bot
Comment 3 2016-10-21 09:16:52 PDT
Comment on attachment 292245 [details] Patch v1 Clearing flags on attachment: 292245 Committed r207676: <http://trac.webkit.org/changeset/207676>
WebKit Commit Bot
Comment 4 2016-10-21 09:16:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.