Bug 163740

Summary: Invalid assertion in arguments elimination
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch msaboff: review+

Description Keith Miller 2016-10-20 10:00:01 PDT 
Invalid assertion in arguments elimination
Comment 1 Keith Miller 2016-10-20 10:08:11 PDT 
Created attachment 292216 [details]
Patch
Comment 2 Keith Miller 2016-10-20 10:09:35 PDT 
Created attachment 292217 [details]
Patch
Comment 3 Keith Miller 2016-10-20 10:11:27 PDT 
<rdar://problem/27911462>
Comment 4 Michael Saboff 2016-10-20 10:31:45 PDT 
Comment on attachment 292217 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292217&action=review

r=me

> Source/JavaScriptCore/ChangeLog:12
> +        number of reasons that a DFG GetFromArguments may not point to another a

Should "another" be removed?
Comment 5 Keith Miller 2016-10-20 10:33:41 PDT 
Comment on attachment 292217 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292217&action=review

Thanks for the review.

>> Source/JavaScriptCore/ChangeLog:12
>> +        number of reasons that a DFG GetFromArguments may not point to another a
> 
> Should "another" be removed?

Fixed.
Comment 6 Keith Miller 2016-10-20 10:43:06 PDT 
Committed r207623: <http://trac.webkit.org/changeset/207623>
Comment 7 Filip Pizlo 2016-10-20 10:44:58 PDT 
Comment on attachment 292217 [details]
Patch

r=me too