Bug 163715

Summary:

Passing a number as the pixel parameter to texImage2D() doesn't thrown an exception

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

WebGL

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, darin, dino, ggaren, rniwa, sam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Test	none
Patch	none

Myles C. Maxfield

Reported 2016-10-19 18:29:53 PDT

The IDL bindings code converts the argument ArrayBufferView? pixels to auto pixels = toArrayBufferView(state->uncheckedArgument(8)); inside JSWebGLRenderingContextBase.cpp toArrayBufferView returns nullptr if the input is a wrong type, so this case is indistinguishable from passing "null" in javascript. However, passing an unknown type should throw an exception, and passing "null" should cause "a buffer of sufficient size initialized to 0 is passed."

Attachments
Test (5.08 KB, patch) 2016-10-20 10:15 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (8.34 KB, patch) 2016-10-20 11:51 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.