Bug 163695

Summary:

Add support for sequences and dictionaries in unions

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, jiewen_tan

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	cdumez: review+

Sam Weinig

Reported 2016-10-19 14:42:54 PDT

Add support for sequences and dictionaries in unions

Attachments
Patch (22.75 KB, patch) 2016-10-19 14:49 PDT, Sam Weinig	cdumez: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2016-10-19 14:49:45 PDT

Created attachment 292113 [details] Patch

WebKit Commit Bot

Comment 2 2016-10-19 14:51:02 PDT

Attachment 292113 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/JSDOMConvert.h:481: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebCore/bindings/js/JSDOMConvert.h:482: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebCore/bindings/js/JSDOMConvert.h:487: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebCore/bindings/js/JSDOMConvert.h:488: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebCore/bindings/js/JSDOMConvert.h:492: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebCore/bindings/js/JSDOMConvert.h:493: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebCore/bindings/js/JSDOMConvert.h:497: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebCore/bindings/js/JSDOMConvert.h:498: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebCore/bindings/js/JSDOMConvert.h:502: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebCore/bindings/js/JSDOMConvert.h:503: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebCore/bindings/js/JSDOMConvert.h:524: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebCore/bindings/js/JSDOMConvert.h:569: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebCore/bindings/js/JSDOMConvert.h:582: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebCore/bindings/js/JSDOMConvert.h:592: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 14 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 3 2016-10-19 15:03:44 PDT

Comment on attachment 292113 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292113&action=review > Source/WebCore/testing/TypeConversions.idl:58 > + readonly attribute DOMString typeConversionsDictionaryUnionType; // Returns one of the following strings: "Node", "sequence<DOMString>", "Dictionary"." Seems like this should use an IDL string enumeration? > LayoutTests/js/dom/webidl-type-mapping.html:596 > +// Test (DOMString or sequence<DOMString>) I do not understand this comment. it seems to test something else.

Sam Weinig

Comment 4 2016-10-19 15:07:37 PDT

(In reply to comment #3) > Comment on attachment 292113 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=292113&action=review > > > Source/WebCore/testing/TypeConversions.idl:58 > > + readonly attribute DOMString typeConversionsDictionaryUnionType; // Returns one of the following strings: "Node", "sequence<DOMString>", "Dictionary"." > > Seems like this should use an IDL string enumeration? > > > LayoutTests/js/dom/webidl-type-mapping.html:596 > > +// Test (DOMString or sequence<DOMString>) > > I do not understand this comment. it seems to test something else. Oops. From an earlier version. Fixed.

Sam Weinig

Comment 5 2016-10-19 16:33:57 PDT

Committed r207575: <http://trac.webkit.org/changeset/207575>

Jiewen Tan

Comment 6 2016-10-21 17:35:12 PDT

*** Bug 163619 has been marked as a duplicate of this bug. ***

Jiewen Tan

Comment 7 2016-10-21 17:35:30 PDT

*** Bug 163614 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.