Summary: | [CSS Parser] Fix named color parsing | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dave Hyatt <hyatt> | ||||
Component: | CSS | Assignee: | Dave Hyatt <hyatt> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Dave Hyatt
2016-10-19 08:54:20 PDT
Created attachment 292067 [details]
Patch
Attachment 292067 [details] did not pass style-queue:
ERROR: Source/WebCore/css/StyleResolver.cpp:123: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 292067 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292067&action=review > Source/WebCore/css/StyleResolver.cpp:1817 > + default: { > + return StyleColor::colorFromKeyword(ident); > + } No need for these braces. |