Summary: | [Xcode] JavaScriptCore fails to build when CLANG_WARN_DOCUMENTATION_COMMENTS is enabled | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | mitz | ||||
Component: | JavaScriptCore | Assignee: | mitz | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, commit-queue, ggaren, keith_miller, mark.lam, msaboff, saam | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Safari Technology Preview | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
mitz
2016-10-18 19:09:15 PDT
Created attachment 292025 [details]
Enable and address documentation warnings
Attachment 292025 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/API/JSValueRef.h:96: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/API/JSContextRefInternal.h:53: The parameter name "runLoop" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/API/JSWeakObjectMapRefPrivate.h:67: The parameter name "map" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/API/JSWeakObjectMapRefPrivate.h:67: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/API/JSContextRefPrivate.h:88: The parameter name "group" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/API/JSContextRefPrivate.h:88: The parameter name "callback" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/API/JSContextRefPrivate.h:95: The parameter name "group" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 7 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 292025 [details] Enable and address documentation warnings Clearing flags on attachment: 292025 Committed r207542: <http://trac.webkit.org/changeset/207542> All reviewed patches have been landed. Closing bug. |