Bug 163634

Summary: Add an beforeunload alert to the WebKitLegacy MiniBrowser
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Anders Carlsson
Reported 2016-10-18 17:12:29 PDT
Add an beforeunload alert to the WebKitLegacy MiniBrowser
Attachments
Patch (1.73 KB, patch)
2016-10-18 17:13 PDT, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2016-10-18 17:13:50 PDT
Created attachment 292007 [details] Patch
Sam Weinig
Comment 2 2016-10-18 17:16:58 PDT
Comment on attachment 292007 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292007&action=review > Tools/MiniBrowser/mac/WK1BrowserWindowController.m:376 > + NSAlert* alert = [[NSAlert alloc] init]; * on the wrong side.
Sam Weinig
Comment 3 2016-10-18 17:17:51 PDT
Comment on attachment 292007 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292007&action=review > Tools/MiniBrowser/mac/WK1BrowserWindowController.m:379 > + [alert setMessageText:[NSString stringWithFormat:@"JavaScript before unload dialog from %@.", frame.dataSource.request.URL.absoluteString]]; > + [alert setInformativeText:message]; Should use property notation.
Anders Carlsson
Comment 4 2016-10-18 17:24:47 PDT
Committed r207508: <http://trac.webkit.org/changeset/207508>
Note You need to log in before you can comment on or make changes to this bug.