| Summary: | [Web IDL] Kill support for [LegacyConstructorTemplate=Event] / [LegacyInitializedByEventConstructor] | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> |
| Component: | Bindings | Assignee: | Chris Dumez <cdumez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | buildbot, cdumez, commit-queue, darin, dbates, esprehn+autocc, kangil.han, kondapallykalyan, rniwa, sam |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Attachments: | |||
|
Description
Chris Dumez
2016-10-18 16:29:44 PDT
Created attachment 292000 [details]
Patch
Created attachment 292006 [details]
Patch
Finally \o/ Comment on attachment 292006 [details]
Patch
I’m surprised that you didn’t have to rename EventInit to Event::Init and UIEventInit to UIEvent::Init.
(In reply to comment #4) > Comment on attachment 292006 [details] > Patch > > I’m surprised that you didn’t have to rename EventInit to Event::Init and > UIEventInit to UIEvent::Init. Because they are defined in their own idl file. Comment on attachment 292006 [details] Patch Attachment 292006 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2319490 New failing tests: fast/events/constructors/event-constructors.html fast/events/constructors/ui-event-constructor.html Created attachment 292016 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 292006 [details] Patch Attachment 292006 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2319535 New failing tests: fast/events/constructors/event-constructors.html fast/events/constructors/ui-event-constructor.html Created attachment 292018 [details]
Archive of layout-test-results from ews102 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 292006 [details] Patch Attachment 292006 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2319482 New failing tests: fast/events/constructors/event-constructors.html fast/events/constructors/ui-event-constructor.html Created attachment 292019 [details]
Archive of layout-test-results from ews113 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 292006 [details] Patch Attachment 292006 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2319492 New failing tests: fast/events/constructors/event-constructors.html fast/events/constructors/ui-event-constructor.html Created attachment 292020 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Created attachment 292024 [details]
Patch
Comment on attachment 292024 [details] Patch Clearing flags on attachment: 292024 Committed r207515: <http://trac.webkit.org/changeset/207515> All reviewed patches have been landed. Closing bug. |