| Summary: | Add a MiniBrowser menu item to apply page scale in WK1 and WK2 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, simon.fraser, thorton | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Simon Fraser (smfr)
2016-10-18 15:37:10 PDT
Created attachment 291994 [details]
Patch
Attachment 291994 [details] did not pass style-queue:
ERROR: Source/WebKit/mac/WebView/WebViewPrivate.h:0: Use #pragma once header guard. [build/header_guard] [5]
ERROR: Tools/MiniBrowser/mac/BrowserWindowController.h:0: Use #pragma once header guard. [build/header_guard] [5]
ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:0: Use #pragma once header guard. [build/header_guard] [5]
Total errors found: 3 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 292004 [details]
Patch
Attachment 292004 [details] did not pass style-queue:
ERROR: Source/WebKit/mac/WebView/WebViewPrivate.h:0: Use #pragma once header guard. [build/header_guard] [5]
ERROR: Tools/MiniBrowser/mac/BrowserWindowController.h:0: Use #pragma once header guard. [build/header_guard] [5]
ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:0: Use #pragma once header guard. [build/header_guard] [5]
Total errors found: 3 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 292004 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292004&action=review > Tools/MiniBrowser/mac/BrowserWindowController.m:170 > + if (tag == 1) > + return 1; > + if (tag == 2) > + return 1.25; > + if (tag == 3) > + return 1.5; > + if (tag == 4) > + return 2.0; > + Nothing < 1? |