Bug 163625

Summary: Simplify SerializedScriptValue, MessagePortArray and ArrayBufferArray to ease generation
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, beidson, cdumez, commit-queue, dbates, esprehn+autocc, jsbell, kangil.han, kondapallykalyan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch cdumez: review+

Sam Weinig
Reported 2016-10-18 15:05:34 PDT
Simplify SerializedScriptValue, MessagePortArray and ArrayBufferArray to ease generation
Attachments
Patch (60.51 KB, patch)
2016-10-18 15:06 PDT, Sam Weinig 		cdumez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2016-10-18 15:06:23 PDT
Created attachment 291992 [details] Patch
WebKit Commit Bot
Comment 2 2016-10-18 15:08:58 PDT
Attachment 291992 [details] did not pass style-queue: ERROR: Source/WebCore/dom/MessagePort.cpp:196: Omit int when using unsigned [runtime/unsigned] [1] Total errors found: 1 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 3 2016-10-18 16:17:34 PDT
Comment on attachment 291992 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=291992&action=review r=me > Source/WebCore/bindings/js/JSMessagePortCustom.h:60 > + extractTransferables(state, state.argument(1), messagePortArray, arrayBufferArray); uncheckedArgument(1)
Sam Weinig
Comment 4 2016-10-18 17:06:41 PDT
(In reply to comment #3) > Comment on attachment 291992 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=291992&action=review > > r=me > > > Source/WebCore/bindings/js/JSMessagePortCustom.h:60 > > + extractTransferables(state, state.argument(1), messagePortArray, arrayBufferArray); > > uncheckedArgument(1) I don't think we can. We are only checking that the argument count is at least 1.
Sam Weinig
Comment 5 2016-10-18 17:07:51 PDT
Committed r207505: <http://trac.webkit.org/changeset/207505>
Chris Dumez
Comment 6 2016-10-18 18:28:53 PDT
Comment on attachment 291992 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=291992&action=review >>> Source/WebCore/bindings/js/JSMessagePortCustom.h:60 >>> + extractTransferables(state, state.argument(1), messagePortArray, arrayBufferArray); >> >> uncheckedArgument(1) > > I don't think we can. We are only checking that the argument count is at least 1. Duh. Sorry I misread.
Note You need to log in before you can comment on or make changes to this bug.