Bug 163625

Summary: Simplify SerializedScriptValue, MessagePortArray and ArrayBufferArray to ease generation
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, beidson, cdumez, commit-queue, dbates, esprehn+autocc, jsbell, kangil.han, kondapallykalyan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch cdumez: review+

Description Sam Weinig 2016-10-18 15:05:34 PDT 
Simplify SerializedScriptValue, MessagePortArray and ArrayBufferArray to ease generation
Comment 1 Sam Weinig 2016-10-18 15:06:23 PDT 
Created attachment 291992 [details]
Patch
Comment 2 WebKit Commit Bot 2016-10-18 15:08:58 PDT 
Attachment 291992 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/MessagePort.cpp:196:  Omit int when using unsigned  [runtime/unsigned] [1]
Total errors found: 1 in 30 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Chris Dumez 2016-10-18 16:17:34 PDT 
Comment on attachment 291992 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291992&action=review

r=me

> Source/WebCore/bindings/js/JSMessagePortCustom.h:60
> +        extractTransferables(state, state.argument(1), messagePortArray, arrayBufferArray);

uncheckedArgument(1)
Comment 4 Sam Weinig 2016-10-18 17:06:41 PDT 
(In reply to comment #3)
> Comment on attachment 291992 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=291992&action=review
> 
> r=me
> 
> > Source/WebCore/bindings/js/JSMessagePortCustom.h:60
> > +        extractTransferables(state, state.argument(1), messagePortArray, arrayBufferArray);
> 
> uncheckedArgument(1)

I don't think we can. We are only checking that the argument count is at least 1.
Comment 5 Sam Weinig 2016-10-18 17:07:51 PDT 
Committed r207505: <http://trac.webkit.org/changeset/207505>
Comment 6 Chris Dumez 2016-10-18 18:28:53 PDT 
Comment on attachment 291992 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291992&action=review

>>> Source/WebCore/bindings/js/JSMessagePortCustom.h:60
>>> +        extractTransferables(state, state.argument(1), messagePortArray, arrayBufferArray);
>> 
>> uncheckedArgument(1)
> 
> I don't think we can. We are only checking that the argument count is at least 1.

Duh. Sorry I misread.