Bug 163611

Summary: [WebIDL] Allow sequences of dictionaries as members of other dictionaries and as parameters
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, kondapallykalyan, sam, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 163624    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Zan Dobersek
Reported 2016-10-18 12:32:46 PDT
[WebIDL] Allow sequences of dictionaries as members of other dictionaries and as parameters
Attachments
Patch (9.43 KB, patch)
2016-10-18 12:44 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2016-10-18 12:44:53 PDT
Created attachment 291970 [details] Patch
Sam Weinig
Comment 2 2016-10-18 12:48:43 PDT
This makes me think that Converter<IDLDictionary<T>>::convert() should maybe return a T not Optional<T>. I need to think through what the consequences of this would be.
Chris Dumez
Comment 3 2016-10-18 12:56:17 PDT
(In reply to comment #2) > This makes me think that Converter<IDLDictionary<T>>::convert() should maybe > return a T not Optional<T>. I need to think through what the consequences > of this would be. I think I made the switch to returning Optional a while back so we could return Nullopt in error cases. However, since then, we updated our dictionary code so that all our native dictionary structs must have a default constructor. Therefore, I think it is no longer necessary to return an Optional<>, we can just return { } instead. So I agree with Sam.
Chris Dumez
Comment 4 2016-10-18 12:57:00 PDT
@Zan: I am happy to make the code change if you want. Just let me know.
Zan Dobersek
Comment 5 2016-10-18 23:19:37 PDT
(In reply to comment #4) > @Zan: I am happy to make the code change if you want. Just let me know. Saw it in bug #163624. Thanks! With that this patch isn't needed anymore.
Note You need to log in before you can comment on or make changes to this bug.