Bug 163586

Summary: [DOMJIT] Use NativeCallFrameTracer for operations used for DOMJIT slow calls
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, fpizlo, keith_miller, mark.lam, msaboff, ossy, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 163223    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch saam: review+

Yusuke Suzuki
Reported 2016-10-17 23:24:56 PDT
DOMJIT slow calls should use NativeCallFrameTracer as the same to the other operations.
Attachments
Patch (12.08 KB, patch)
2016-10-17 23:40 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (25.44 KB, patch)
2016-10-18 00:08 PDT, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2016-10-17 23:40:10 PDT
Created attachment 291924 [details] Patch
Yusuke Suzuki
Comment 2 2016-10-18 00:08:46 PDT
Created attachment 291927 [details] Patch
Saam Barati
Comment 3 2016-10-18 01:02:04 PDT
Comment on attachment 291927 [details] Patch r=me
Yusuke Suzuki
Comment 4 2016-10-18 01:16:12 PDT
Committed r207456: <http://trac.webkit.org/changeset/207456>
Csaba Osztrogonác
Comment 5 2016-10-18 02:43:50 PDT
(In reply to comment #4) > Committed r207456: <http://trac.webkit.org/changeset/207456> It broke the Apple Mac cmake build: In file included from /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebCore/domjit/JSNodeDOMJIT.cpp:36: /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebCore/ForwardingHeaders/interpreter/FrameTracers.h:28:10: fatal error: 'JavaScriptCore/FrameTracers.h' file not found #include <JavaScriptCore/FrameTracers.h> ^ 1 error generated.
Yusuke Suzuki
Comment 6 2016-10-18 11:49:39 PDT
(In reply to comment #5) > (In reply to comment #4) > > Committed r207456: <http://trac.webkit.org/changeset/207456> > > It broke the Apple Mac cmake build: > > In file included from > /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebCore/domjit/ > JSNodeDOMJIT.cpp:36: > /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebCore/ > ForwardingHeaders/interpreter/FrameTracers.h:28:10: fatal error: > 'JavaScriptCore/FrameTracers.h' file not found > #include <JavaScriptCore/FrameTracers.h> > ^ > 1 error generated. This is related to forwarding header clean up in CMake. Rebuilding fixes the issue[1]. (JSNodeDOMJIT.cpp is compiled correctly) [1]: https://build.webkit.org/builders/Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/9293/steps/compile-webkit/logs/stdio
Note You need to log in before you can comment on or make changes to this bug.