Bug 163583

Summary: REGRESSION(r201171): Web Inspector: Timeline Recording playhead should always start immediately, not wait until first event
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, joepeck, mattbaker, nvasilyev, simon.fraser, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2016-10-17 20:31:56 PDT
Summary: Timeline Recording playhead should always start immediately, not wait until first event Steps to Reproduce: 1. Inspect a page 2. Start a timeline recording 3. Wait 10 seconds 4. Interact with the page Expected Behavior: Timeline UI starts updating immediately at (2) Actual Behavior: Timeline UI starts updating at (4) Regression: Almost certainly this is a regression from earlier behavior.
Attachments
[PATCH] Proposed Fix (2.12 KB, patch)
2016-10-17 20:41 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-10-17 20:32:14 PDT
<rdar://problem/28815882>
Joseph Pecoraro
Comment 2 2016-10-17 20:38:53 PDT
Looks like this would have regressed with: <https://trac.webkit.org/r201171> This changed some logic that it didn't need to and it looks like it changed it incorrectly.
Joseph Pecoraro
Comment 3 2016-10-17 20:41:35 PDT
Created attachment 291915 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 4 2016-10-17 20:48:10 PDT
Comment on attachment 291915 [details] [PATCH] Proposed Fix After re-reading the original change, I still don't understand why this change would have been made, so setting cq? again.
WebKit Commit Bot
Comment 5 2016-10-18 11:10:59 PDT
Comment on attachment 291915 [details] [PATCH] Proposed Fix Clearing flags on attachment: 291915 Committed r207473: <http://trac.webkit.org/changeset/207473>
WebKit Commit Bot
Comment 6 2016-10-18 11:11:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.