| Summary: | Update TrackEvent to stop using legacy [ConstructorTemplate=Event] | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
| Component: | Bindings | Assignee: | Chris Dumez <cdumez> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cdumez, commit-queue, darin, sam | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Chris Dumez
2016-10-17 19:24:48 PDT
Created attachment 291911 [details]
Patch
Comment on attachment 291911 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=291911&action=review > Source/WebCore/html/track/TrackEvent.idl:30 > + [CustomGetter] readonly attribute (VideoTrack or AudioTrack or TextTrack)? track; It would be nice to work towards getting rid of this CustomGetter by storing the track as a variant, but let's come back to that later. Comment on attachment 291911 [details] Patch Clearing flags on attachment: 291911 Committed r207468: <http://trac.webkit.org/changeset/207468> All reviewed patches have been landed. Closing bug. Comment on attachment 291911 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=291911&action=review >> Source/WebCore/html/track/TrackEvent.idl:30 >> + [CustomGetter] readonly attribute (VideoTrack or AudioTrack or TextTrack)? track; > > It would be nice to work towards getting rid of this CustomGetter by storing the track as a variant, but let's come back to that later. All we’d need is a track() function that returns a variant. Don’t necessarily need to store it as a variant! Comment on attachment 291911 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=291911&action=review >>> Source/WebCore/html/track/TrackEvent.idl:30 >>> + [CustomGetter] readonly attribute (VideoTrack or AudioTrack or TextTrack)? track; >> >> It would be nice to work towards getting rid of this CustomGetter by storing the track as a variant, but let's come back to that later. > > All we’d need is a track() function that returns a variant. Don’t necessarily need to store it as a variant! We'd need a toJS() implementation that properly deals with std::variant as well. |