| Summary: | Move some history specific HistoryItem code to WebHistoryItem | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||||||
| Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | cdumez, commit-queue | ||||||||
| Priority: | P2 | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Anders Carlsson
2016-10-17 15:09:34 PDT
Created attachment 291883 [details]
Patch
Attachment 291883 [details] did not pass style-queue:
ERROR: Source/WebKit/mac/History/WebHistoryItemInternal.h:0: Use #pragma once header guard. [build/header_guard] [5]
Total errors found: 1 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 291883 [details] Patch Attachment 291883 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2307370 New failing tests: animations/CSSKeyframesRule-name-null.html Created attachment 291893 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Created attachment 291957 [details]
Patch
Attachment 291957 [details] did not pass style-queue:
ERROR: Source/WebKit/mac/History/WebHistoryItemInternal.h:0: Use #pragma once header guard. [build/header_guard] [5]
Total errors found: 1 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r207482: <http://trac.webkit.org/changeset/207482> |