RESOLVED FIXED Bug 163567
Move some history specific HistoryItem code to WebHistoryItem 
https://bugs.webkit.org/show_bug.cgi?id=163567
Summary Move some history specific HistoryItem code to WebHistoryItem
Anders Carlsson
Reported 2016-10-17 15:09:34 PDT
Move some history specific HistoryItem code to WebHistoryItem
Attachments
Patch (9.77 KB, patch)
2016-10-17 15:11 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (3.45 MB, application/zip)
2016-10-17 16:25 PDT, Build Bot 		no flags
Details
Patch (14.68 KB, patch)
2016-10-18 10:35 PDT, Anders Carlsson 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2016-10-17 15:11:49 PDT
Created attachment 291883 [details] Patch
WebKit Commit Bot
Comment 2 2016-10-17 15:15:11 PDT
Attachment 291883 [details] did not pass style-queue: ERROR: Source/WebKit/mac/History/WebHistoryItemInternal.h:0: Use #pragma once header guard. [build/header_guard] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 3 2016-10-17 16:25:26 PDT
Comment on attachment 291883 [details] Patch Attachment 291883 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2307370 New failing tests: animations/CSSKeyframesRule-name-null.html
Build Bot
Comment 4 2016-10-17 16:25:29 PDT
Created attachment 291893 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Anders Carlsson
Comment 5 2016-10-18 10:35:30 PDT
Created attachment 291957 [details] Patch
WebKit Commit Bot
Comment 6 2016-10-18 10:36:42 PDT
Attachment 291957 [details] did not pass style-queue: ERROR: Source/WebKit/mac/History/WebHistoryItemInternal.h:0: Use #pragma once header guard. [build/header_guard] [5] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 7 2016-10-18 13:25:42 PDT
Committed r207482: <http://trac.webkit.org/changeset/207482>
Note You need to log in before you can comment on or make changes to this bug.