Summary: | CSS font-variation-settings should not handle uppercase axis names in variable fonts | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Laurence Penney <lorp> | ||||||
Component: | Text | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, dino, jonlee, lorp, mmaxfield, thorton, webkit-bug-importer, zalan | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Mac | ||||||||
OS: | macOS 10.12 | ||||||||
Attachments: |
|
Description
Laurence Penney
2016-10-17 09:20:58 PDT
Where can I get a copy of these fonts to test them out? Created attachment 292108 [details]
Patch
Comment on attachment 292108 [details] Patch Attachment 292108 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2326585 New failing tests: media/controls/ipad/close-page-with-picture-in-picture-video-assertion-failure.html Created attachment 292115 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 292108 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292108&action=review > Source/WebCore/css/parser/CSSParser.cpp:10596 > - tag[i] = toASCIILower(character); > + tag[i] = character; Did you do the same in the new parser code? > LayoutTests/fast/text/variations/case-axis-names.html:7 > +This test passes if capitalized and lowercased axis names are distinct. > +<div style="font: 100px '-apple-system'; font-variation-settings: 'WGHT' 1.8;">Hello</div> Am I confused? The -expected version of this test doesn't use any variation, so what is it testing? Comment on attachment 292108 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292108&action=review >> LayoutTests/fast/text/variations/case-axis-names.html:7 >> +<div style="font: 100px '-apple-system'; font-variation-settings: 'WGHT' 1.8;">Hello</div> > > Am I confused? The -expected version of this test doesn't use any variation, so what is it testing? The test is testing that "wght" is different from "WGHT". The font only responds to "wght" so if you specify "WGHT" it should be the same as specifying nothing. Comment on attachment 292108 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292108&action=review >>> LayoutTests/fast/text/variations/case-axis-names.html:7 >>> +<div style="font: 100px '-apple-system'; font-variation-settings: 'WGHT' 1.8;">Hello</div> >> >> Am I confused? The -expected version of this test doesn't use any variation, so what is it testing? > > The test is testing that "wght" is different from "WGHT". The font only responds to "wght" so if you specify "WGHT" it should be the same as specifying nothing. Ah ok. Can you change the title of the bug to be "should not" rather than "does not"? Comment on attachment 292108 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292108&action=review >> Source/WebCore/css/parser/CSSParser.cpp:10596 >> + tag[i] = character; > > Did you do the same in the new parser code? https://bugs.webkit.org/show_bug.cgi?id=163712 Comment on attachment 292108 [details] Patch Clearing flags on attachment: 292108 Committed r207581: <http://trac.webkit.org/changeset/207581> All reviewed patches have been landed. Closing bug. |