Bug 163507

Summary: Eleminate code duplication between ResourceRequest encoding/decoding implementations
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: WebCore Misc.Assignee: Konstantin Tokarev <annulen>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, cgarcia, commit-queue, danw, gustavo, mcatanzaro, mrobinson
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Konstantin Tokarev
Reported 2016-10-16 12:05:13 PDT
ResourceRequestBase::encodeWithoutPlatformData() and Soup implementation of ArgumentCoder<ResourceRequest>::encodePlatformData() share most of the code, ditto for decoding implementations.
Attachments
Patch (10.36 KB, patch)
2016-10-16 12:07 PDT, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2016-10-16 12:07:33 PDT
Created attachment 291765 [details] Patch
Carlos Garcia Campos
Comment 2 2016-10-17 04:11:17 PDT
Comment on attachment 291765 [details] Patch Great cleanup! Thanks
WebKit Commit Bot
Comment 3 2016-10-17 05:02:39 PDT
Comment on attachment 291765 [details] Patch Clearing flags on attachment: 291765 Committed r207407: <http://trac.webkit.org/changeset/207407>
WebKit Commit Bot
Comment 4 2016-10-17 05:02:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.